From 4e3c709ebed4c082c0d03b06d3cf505c0c042c5a Mon Sep 17 00:00:00 2001 From: Sowmya V Date: Thu, 19 Sep 2024 11:34:11 +0530 Subject: mb/google/nissa/var/nivviks: Update the power resource for NVM and VCM Earlier change (https://review.coreboot.org/c/coreboot/+/84019) pushed to resolve the privacy LED blinking issue regressed the camera autofocus functionality. This change updates the power resource for NVM and VCM in line with the tivviks schematics to fix the issue. BUG=b:365899407 TEST=Build and boot tivviks. Verified the Autofocus and all the camera basic sanity tests. Change-Id: Id3e256d59982ac176844e289f18ee450079704b9 Signed-off-by: Sowmya V Reviewed-on: https://review.coreboot.org/c/coreboot/+/84420 Tested-by: build bot (Jenkins) Reviewed-by: Subrata Banik Reviewed-by: Eric Lai Reviewed-by: Ronak Kanabar --- .../google/brya/variants/nivviks/overridetree.cb | 22 +++++++++++++++++++--- 1 file changed, 19 insertions(+), 3 deletions(-) (limited to 'src') diff --git a/src/mainboard/google/brya/variants/nivviks/overridetree.cb b/src/mainboard/google/brya/variants/nivviks/overridetree.cb index 67c4734650..ec7015a552 100644 --- a/src/mainboard/google/brya/variants/nivviks/overridetree.cb +++ b/src/mainboard/google/brya/variants/nivviks/overridetree.cb @@ -437,14 +437,17 @@ chip soc/intel/alderlake # Controls register "gpio_panel.gpio[0].gpio_num" = "GPP_D15" # EN_PP2800_WCAM_X + register "gpio_panel.gpio[1].gpio_num" = "GPP_D16" # EN_PP1800_PP1200_WCAM_X # _ON - register "on_seq.ops_cnt" = "1" + register "on_seq.ops_cnt" = "2" register "on_seq.ops[0]" = "SEQ_OPS_GPIO_ENABLE(0, 5)" + register "on_seq.ops[1]" = "SEQ_OPS_GPIO_ENABLE(1, 5)" # _OFF - register "off_seq.ops_cnt" = "1" - register "off_seq.ops[0]" = "SEQ_OPS_GPIO_DISABLE(0, 0)" + register "off_seq.ops_cnt" = "2" + register "off_seq.ops[0]" = "SEQ_OPS_GPIO_DISABLE(1, 0)" + register "off_seq.ops[1]" = "SEQ_OPS_GPIO_DISABLE(0, 0)" device i2c 0C on probe WFC WFC_MIPI_OVTI5675 @@ -456,6 +459,19 @@ chip soc/intel/alderlake register "acpi_name" = ""NVM0"" register "chip_name" = ""GT24C08"" register "device_type" = "INTEL_ACPI_CAMERA_NVM" + register "has_power_resource" = "1" + register "max_dstate_for_probe" = "ACPI_DEVICE_SLEEP_D3_COLD" + + # Controls + register "gpio_panel.gpio[0].gpio_num" = "GPP_D16" # EN_PP1800_PP1200_WCAM_X + + # _ON + register "on_seq.ops_cnt" = "1" + register "on_seq.ops[0]" = "SEQ_OPS_GPIO_ENABLE(0, 5)" + + # _OFF + register "off_seq.ops_cnt" = "1" + register "off_seq.ops[0]" = "SEQ_OPS_GPIO_DISABLE(0, 0)" register "nvm_size" = "0x2000" register "nvm_pagesize" = "1" -- cgit v1.2.3