From 48368892496e333075aa02b7aa2f2d7ba10e8f60 Mon Sep 17 00:00:00 2001
From: Felix Held <felix-coreboot@felixheld.de>
Date: Fri, 29 Jan 2021 22:18:25 +0100
Subject: soc/amd/picasso/psp: fix check of MSR_PSP_ADDR contents

If MSR_PSP_ADDR is uninitialized, it's all zeros and not all ones.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Iecd3039f63f9d0cb75fe3cb37aee92ba65bbbb50
Reviewed-on: https://review.coreboot.org/c/coreboot/+/50148
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
---
 src/soc/amd/picasso/psp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'src')

diff --git a/src/soc/amd/picasso/psp.c b/src/soc/amd/picasso/psp.c
index ddefd22bd0..6acb5888ce 100644
--- a/src/soc/amd/picasso/psp.c
+++ b/src/soc/amd/picasso/psp.c
@@ -14,7 +14,7 @@ void *soc_get_mbox_address(void)
 	uintptr_t psp_mmio;
 
 	psp_mmio = rdmsr(MSR_PSP_ADDR).lo;
-	if (psp_mmio == 0xffffffff) {
+	if (!psp_mmio) {
 		printk(BIOS_WARNING, "PSP: MSR_PSP_ADDR uninitialized\n");
 		return 0;
 	}
-- 
cgit v1.2.3