From 47df66d7654f515594bdc6e60d8a87a8ebe7a3c6 Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Sat, 17 Nov 2018 15:17:38 +0530 Subject: soc/intel/{cnl, icl}: Remove unnecessary __SIMPLE_DEVICE__ check soc_pch_pirq_init() function is only getting compiled for RAMSTAGE hence remove unused __SIMPLE_DEVICE__ check. Change-Id: I7f0ca62170f0af12a251c8c97155de8433a31854 Signed-off-by: Subrata Banik Reviewed-on: https://review.coreboot.org/29643 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber --- src/soc/intel/cannonlake/lpc.c | 7 ++----- src/soc/intel/icelake/lpc.c | 7 ++----- 2 files changed, 4 insertions(+), 10 deletions(-) (limited to 'src') diff --git a/src/soc/intel/cannonlake/lpc.c b/src/soc/intel/cannonlake/lpc.c index b440d392e4..0195cefb84 100644 --- a/src/soc/intel/cannonlake/lpc.c +++ b/src/soc/intel/cannonlake/lpc.c @@ -145,6 +145,7 @@ static void pch_enable_ioapic(const struct device *dev) void soc_pch_pirq_init(const struct device *dev) { + struct device *irq_dev; uint8_t pch_interrupt_routing[MAX_PXRC_CONFIG]; pch_interrupt_routing[0] = PCH_IRQ11; @@ -157,11 +158,7 @@ void soc_pch_pirq_init(const struct device *dev) pch_interrupt_routing[7] = PCH_IRQ11; itss_irq_init(pch_interrupt_routing); -#if defined(__SIMPLE_DEVICE__) - pci_devfn_t irq_dev; -#else - struct device *irq_dev; -#endif + for (irq_dev = all_devices; irq_dev; irq_dev = irq_dev->next) { u8 int_pin = 0, int_line = 0; diff --git a/src/soc/intel/icelake/lpc.c b/src/soc/intel/icelake/lpc.c index 93d543f444..9bf1b789dd 100644 --- a/src/soc/intel/icelake/lpc.c +++ b/src/soc/intel/icelake/lpc.c @@ -144,6 +144,7 @@ static void pch_enable_ioapic(const struct device *dev) void soc_pch_pirq_init(const struct device *dev) { + struct device *irq_dev; uint8_t pch_interrupt_routing[MAX_PXRC_CONFIG]; pch_interrupt_routing[0] = PCH_IRQ11; @@ -156,11 +157,7 @@ void soc_pch_pirq_init(const struct device *dev) pch_interrupt_routing[7] = PCH_IRQ11; itss_irq_init(pch_interrupt_routing); -#if defined(__SIMPLE_DEVICE__) - pci_devfn_t irq_dev; -#else - struct device *irq_dev; -#endif + for (irq_dev = all_devices; irq_dev; irq_dev = irq_dev->next) { u8 int_pin = 0, int_line = 0; -- cgit v1.2.3