From 45041caaba3de044207bacd7ef4286e66707f662 Mon Sep 17 00:00:00 2001 From: Sean Rhodes Date: Thu, 17 Feb 2022 14:24:03 +0000 Subject: ec/starlabs: Correct Keyboard Backlight offsets for GLK Correct the offsets used for the keyboard backlight control: ECRAM_KBL_STATE 0x19 ECRAM_KBL_BRIGHTNESS 0x18 Signed-off-by: Sean Rhodes Change-Id: I23bac43301635e6b18f1cbd28311e7210b049c70 Reviewed-on: https://review.coreboot.org/c/coreboot/+/62126 Tested-by: build bot (Jenkins) Reviewed-by: Andy Pont Reviewed-by: Angel Pons --- src/ec/starlabs/merlin/variants/glk/ecdefs.h | 4 ++-- src/ec/starlabs/merlin/variants/glk/emem.asl | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'src') diff --git a/src/ec/starlabs/merlin/variants/glk/ecdefs.h b/src/ec/starlabs/merlin/variants/glk/ecdefs.h index 5f43991aef..b09ffc76f0 100644 --- a/src/ec/starlabs/merlin/variants/glk/ecdefs.h +++ b/src/ec/starlabs/merlin/variants/glk/ecdefs.h @@ -15,8 +15,8 @@ /* EC RAM offsets. */ #define ECRAM_TRACKPAD_STATE 0x14 -#define ECRAM_KBL_STATE 0x18 -#define ECRAM_KBL_BRIGHTNESS 0x19 +#define ECRAM_KBL_STATE 0x19 +#define ECRAM_KBL_BRIGHTNESS 0x18 #define ECRAM_KBL_TIMEOUT 0x1a #define ECRAM_FN_LOCK_STATE 0x2c #define ECRAM_FN_CTRL_REVERSE 0x2d diff --git a/src/ec/starlabs/merlin/variants/glk/emem.asl b/src/ec/starlabs/merlin/variants/glk/emem.asl index d30b58c5bf..9173745fb5 100644 --- a/src/ec/starlabs/merlin/variants/glk/emem.asl +++ b/src/ec/starlabs/merlin/variants/glk/emem.asl @@ -20,8 +20,8 @@ Field (ECF2, ByteAcc, Lock, Preserve) AFG3, 8, // After G3 CLTP, 8, // Close Trackpad WKOL, 8, // Wake on Lid - KLSE, 8, // Keyboard Backlight State KLBE, 8, // Keyboard Backlight Brightness + KLSE, 8, // Keyboard Backlight State Offset(0x1a), KLTE, 8, // Keyboard Backlight Timeout -- cgit v1.2.3