From 3f16a0f1133930b6b33c6995fbafa6c9b2dc5245 Mon Sep 17 00:00:00 2001 From: Richard Spiegel Date: Mon, 6 Aug 2018 11:06:08 -0700 Subject: soc/amd/stoneyridge/acpi.c: Remove fixed value variables In procedure generate_cpu_entries(), the code was copied from code that could change variables "plen" and "pcontrol_blk" based on number of cores. This is not the case with stoneyridge (2 cores only), and there's no need to use the variables. Remove them and replace with fixed values. BUG=b:112253891 TEST=Build and boot grunt. Change-Id: I0258b19960b050e8da9d218ded3f1f3bfccad163 Signed-off-by: Richard Spiegel Reviewed-on: https://review.coreboot.org/27877 Reviewed-by: Martin Roth Tested-by: build bot (Jenkins) --- src/soc/amd/stoneyridge/acpi.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) (limited to 'src') diff --git a/src/soc/amd/stoneyridge/acpi.c b/src/soc/amd/stoneyridge/acpi.c index 5f9e792df7..466b5451df 100644 --- a/src/soc/amd/stoneyridge/acpi.c +++ b/src/soc/amd/stoneyridge/acpi.c @@ -236,8 +236,7 @@ void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt) void generate_cpu_entries(struct device *device) { - int cores, cpu, plen = 6; - u32 pcontrol_blk = ACPI_GPE0_BLK; + int cores, cpu; struct device *cdb_dev; /* Stoney Ridge is single node, just report # of cores */ @@ -247,14 +246,12 @@ void generate_cpu_entries(struct device *device) printk(BIOS_DEBUG, "ACPI \\_PR report %d core(s)\n", cores); /* Generate BSP \_PR.P000 */ - acpigen_write_processor(0, pcontrol_blk, plen); + acpigen_write_processor(0, ACPI_GPE0_BLK, 6); acpigen_pop_len(); /* Generate AP \_PR.Pxxx */ - pcontrol_blk = 0; - plen = 0; for (cpu = 1; cpu < cores; cpu++) { - acpigen_write_processor(cpu, pcontrol_blk, 0); + acpigen_write_processor(cpu, 0, 0); acpigen_pop_len(); } } -- cgit v1.2.3