From 2c16092a21da83b89ea61b459eecc387966caf8c Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Fri, 6 Sep 2024 18:39:29 -0500 Subject: mb/google/zork: Add Kconfig to set IGD UMA allocation via APCB Add a Kconfig choice to select the IGD UMA allocation, which selects a precompiled ACPB binary with the corresponding UMA value set. Default to the previous value (128MB) for non-ChromeOS builds, and 64MB for ChromeOS as that is the value used there. TEST=build/boot google/morphius, verify UMA size changes with selection via dxdiag tool under Windows. Change-Id: I6debd10527c33ce37ef3ada20955c8f7b7500039 Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/84237 Reviewed-by: Felix Held Tested-by: build bot (Jenkins) --- src/mainboard/google/zork/Kconfig | 21 +++++++++++++++++++++ src/mainboard/google/zork/data.apcb | Bin 4672 -> 0 bytes src/mainboard/google/zork/spd/Makefile.mk | 11 ++++++++++- src/mainboard/google/zork/uma_128.apcb | Bin 0 -> 4672 bytes src/mainboard/google/zork/uma_256.apcb | Bin 0 -> 4672 bytes src/mainboard/google/zork/uma_512.apcb | Bin 0 -> 4672 bytes src/mainboard/google/zork/uma_64.apcb | Bin 0 -> 4672 bytes 7 files changed, 31 insertions(+), 1 deletion(-) delete mode 100644 src/mainboard/google/zork/data.apcb create mode 100644 src/mainboard/google/zork/uma_128.apcb create mode 100644 src/mainboard/google/zork/uma_256.apcb create mode 100644 src/mainboard/google/zork/uma_512.apcb create mode 100644 src/mainboard/google/zork/uma_64.apcb (limited to 'src') diff --git a/src/mainboard/google/zork/Kconfig b/src/mainboard/google/zork/Kconfig index 1fcd06ba8e..1b38d270ee 100644 --- a/src/mainboard/google/zork/Kconfig +++ b/src/mainboard/google/zork/Kconfig @@ -301,4 +301,25 @@ config CHROMEOS_WIFI_SAR select SAR_ENABLE select USE_SAR +choice + prompt "UMA Memory Allocation" + default ZORK_UMA_SIZE_64MB if CHROMEOS + default ZORK_UMA_SIZE_128MB + help + The amount of system memory allocated for the integrated GPU. + +config ZORK_UMA_SIZE_64MB + bool "64MB" + +config ZORK_UMA_SIZE_128MB + bool "128MB" + +config ZORK_UMA_SIZE_256MB + bool "256MB" + +config ZORK_UMA_SIZE_512MB + bool "512MB" + +endchoice + endif # BOARD_GOOGLE_BASEBOARD_TREMBYLE || BOARD_GOOGLE_BASEBOARD_DALBOZ diff --git a/src/mainboard/google/zork/data.apcb b/src/mainboard/google/zork/data.apcb deleted file mode 100644 index ee12694946..0000000000 Binary files a/src/mainboard/google/zork/data.apcb and /dev/null differ diff --git a/src/mainboard/google/zork/spd/Makefile.mk b/src/mainboard/google/zork/spd/Makefile.mk index 3e6509d9ae..1f0b20ce0d 100644 --- a/src/mainboard/google/zork/spd/Makefile.mk +++ b/src/mainboard/google/zork/spd/Makefile.mk @@ -5,7 +5,16 @@ SPD_SOURCES_DIR=$(dir $(word 1, $(SPD_SOURCES))) APCB_SOURCES=$(foreach f, $(basename $(notdir $(SPD_SOURCES))), $(obj)/APCB_$(f).gen) # APCB binary with magic numbers to be replaced by apcb_edit tool -APCB_NAME=data.apcb +ifeq ($(CONFIG_ZORK_UMA_SIZE_64MB),y) +APCB_NAME=uma_64.apcb +else ifeq ($(CONFIG_ZORK_UMA_SIZE_128MB),y) +APCB_NAME=uma_128.apcb +else ifeq ($(CONFIG_ZORK_UMA_SIZE_256MB),y) +APCB_NAME=uma_256.apcb +else ifeq ($(CONFIG_ZORK_UMA_SIZE_512MB),y) +APCB_NAME=uma_512.apcb +endif + APCB_PATH=$(src)/mainboard/$(MAINBOARDDIR) $(obj)/APCB_%.gen: $(SPD_SOURCES_DIR)%.hex \ diff --git a/src/mainboard/google/zork/uma_128.apcb b/src/mainboard/google/zork/uma_128.apcb new file mode 100644 index 0000000000..fd605b4187 Binary files /dev/null and b/src/mainboard/google/zork/uma_128.apcb differ diff --git a/src/mainboard/google/zork/uma_256.apcb b/src/mainboard/google/zork/uma_256.apcb new file mode 100644 index 0000000000..f3bd14fd16 Binary files /dev/null and b/src/mainboard/google/zork/uma_256.apcb differ diff --git a/src/mainboard/google/zork/uma_512.apcb b/src/mainboard/google/zork/uma_512.apcb new file mode 100644 index 0000000000..0914c2a6a3 Binary files /dev/null and b/src/mainboard/google/zork/uma_512.apcb differ diff --git a/src/mainboard/google/zork/uma_64.apcb b/src/mainboard/google/zork/uma_64.apcb new file mode 100644 index 0000000000..99abf34f14 Binary files /dev/null and b/src/mainboard/google/zork/uma_64.apcb differ -- cgit v1.2.3