From 2a71a804cfdc36709ef2500bc265d0228f37e9b7 Mon Sep 17 00:00:00 2001 From: Nicholas Sudsgaard Date: Mon, 25 Nov 2024 02:14:23 +0000 Subject: drivers/pc80/pc: Clean up formatting of PS/2 related ASL code MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This change corrects the indentation and also does the following to have the ASL code written in a more canonical style: - Add space between the operator name and "(". - Use uppercase for hexadecimal values. Change-Id: Ib946599f8ab4d68b16867912743f4a7a5bc0307d Signed-off-by: Nicholas Sudsgaard Reviewed-on: https://review.coreboot.org/c/coreboot/+/85281 Reviewed-by: Jérémy Compostella Reviewed-by: Felix Singer Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel --- src/drivers/pc80/pc/ps2_controller.asl | 1 + src/drivers/pc80/pc/ps2_keyboard.asl | 29 +++++++++++++++-------------- src/drivers/pc80/pc/ps2_mouse.asl | 24 +++++++++++++----------- 3 files changed, 29 insertions(+), 25 deletions(-) (limited to 'src') diff --git a/src/drivers/pc80/pc/ps2_controller.asl b/src/drivers/pc80/pc/ps2_controller.asl index 28e337073e..d781973247 100644 --- a/src/drivers/pc80/pc/ps2_controller.asl +++ b/src/drivers/pc80/pc/ps2_controller.asl @@ -1,3 +1,4 @@ /* SPDX-License-Identifier: GPL-2.0-only */ + #include "ps2_keyboard.asl" #include "ps2_mouse.asl" diff --git a/src/drivers/pc80/pc/ps2_keyboard.asl b/src/drivers/pc80/pc/ps2_keyboard.asl index b3d5efada3..5bbc7932b2 100644 --- a/src/drivers/pc80/pc/ps2_keyboard.asl +++ b/src/drivers/pc80/pc/ps2_keyboard.asl @@ -1,18 +1,19 @@ /* SPDX-License-Identifier: GPL-2.0-only */ - Device (PS2K) // Keyboard - { - Name(_HID, EISAID(CONFIG_PS2K_EISAID)) - Name(_CID, EISAID("PNP030B")) - Name(_CRS, ResourceTemplate() - { - IO (Decode16, 0x60, 0x60, 0x01, 0x01) - IO (Decode16, 0x64, 0x64, 0x01, 0x01) - IRQ (Edge, ActiveHigh, Exclusive) { 0x01 } // IRQ 1 - }) +Device (PS2K) // PS/2 Keyboard +{ + Name (_HID, EISAID (CONFIG_PS2K_EISAID)) + Name (_CID, EISAID ("PNP030B")) + + Name (_CRS, ResourceTemplate() + { + IO (Decode16, 0x60, 0x60, 0x01, 0x01) + IO (Decode16, 0x64, 0x64, 0x01, 0x01) + IRQ (Edge, ActiveHigh, Exclusive) { 0x01 } // IRQ 1 + }) - Method (_STA, 0) - { - Return (0xf) - } + Method (_STA, 0) + { + Return (0x0F) } +} diff --git a/src/drivers/pc80/pc/ps2_mouse.asl b/src/drivers/pc80/pc/ps2_mouse.asl index f9ac4159b2..04d160522f 100644 --- a/src/drivers/pc80/pc/ps2_mouse.asl +++ b/src/drivers/pc80/pc/ps2_mouse.asl @@ -1,15 +1,17 @@ /* SPDX-License-Identifier: GPL-2.0-only */ - Device (PS2M) // Mouse + +Device (PS2M) // PS/2 Mouse +{ + Name (_HID, EISAID (CONFIG_PS2M_EISAID)) + Name (_CID, EISAID ("PNP0F13")) + + Name (_CRS, ResourceTemplate() { - Name(_HID, EISAID(CONFIG_PS2M_EISAID)) - Name(_CID, EISAID("PNP0F13")) - Name(_CRS, ResourceTemplate() - { - IRQ (Edge, ActiveHigh, Exclusive) { 0x0c } // IRQ 12 - }) + IRQ (Edge, ActiveHigh, Exclusive) { 0x0C } // IRQ 12 + }) - Method(_STA, 0) - { - Return (0xf) - } + Method (_STA, 0) + { + Return (0x0F) } +} -- cgit v1.2.3