From 207225c68619d4f4c24138454fd2b622ea76dd47 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Tue, 12 Jul 2022 01:02:48 +0200 Subject: cpu/x86/mp_init: retype do_smm element in mp_state struct to bool The do_smm struct element in the mp_state struct was an int even though it only had two possible states, so change it to bool to make this more obvious. Also change the return type of is_smm_enabled from int to bool. Signed-off-by: Felix Held Change-Id: I8d2d95f0497649d67565243d14a5ab9c9cdda412 Reviewed-on: https://review.coreboot.org/c/coreboot/+/65776 Tested-by: build bot (Jenkins) Reviewed-by: Arthur Heymans --- src/cpu/x86/mp_init.c | 8 ++++---- src/security/intel/stm/SmmStm.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) (limited to 'src') diff --git a/src/cpu/x86/mp_init.c b/src/cpu/x86/mp_init.c index 7cc7fbcd18..3f80694533 100644 --- a/src/cpu/x86/mp_init.c +++ b/src/cpu/x86/mp_init.c @@ -675,23 +675,23 @@ struct mp_state { size_t perm_smsize; size_t smm_save_state_size; uintptr_t reloc_start32_offset; - int do_smm; + bool do_smm; } mp_state; -static int is_smm_enabled(void) +static bool is_smm_enabled(void) { return CONFIG(HAVE_SMI_HANDLER) && mp_state.do_smm; } static void smm_disable(void) { - mp_state.do_smm = 0; + mp_state.do_smm = false; } static void smm_enable(void) { if (CONFIG(HAVE_SMI_HANDLER)) - mp_state.do_smm = 1; + mp_state.do_smm = true; } /* diff --git a/src/security/intel/stm/SmmStm.c b/src/security/intel/stm/SmmStm.c index 1ebe77d2f1..4cb2d0126c 100644 --- a/src/security/intel/stm/SmmStm.c +++ b/src/security/intel/stm/SmmStm.c @@ -72,7 +72,7 @@ extern struct mp_state { uintptr_t perm_smbase; size_t perm_smsize; size_t smm_save_state_size; - int do_smm; + bool do_smm; } mp_state; typedef union { -- cgit v1.2.3