From 1dbbe828d49b33711bcfa6ab7e81a0b0ceea613c Mon Sep 17 00:00:00 2001 From: Alexandru Gagniuc Date: Fri, 28 Aug 2015 19:23:29 -0400 Subject: drivers/intel/fsp1_1: Don't compile GOP support in romstage We don't need the code in romstage, and it saves us a few #ifdefs. Change-Id: I26d867566f07c7d80890cd01bf055be7497130d3 Signed-off-by: Alexandru Gagniuc Reviewed-on: http://review.coreboot.org/11457 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin --- src/drivers/intel/fsp1_1/Makefile.inc | 1 - src/drivers/intel/fsp1_1/fsp_gop.c | 2 -- src/drivers/intel/fsp1_1/fsp_gop.h | 3 +-- 3 files changed, 1 insertion(+), 5 deletions(-) (limited to 'src') diff --git a/src/drivers/intel/fsp1_1/Makefile.inc b/src/drivers/intel/fsp1_1/Makefile.inc index 05dbfe584f..f831f9d696 100644 --- a/src/drivers/intel/fsp1_1/Makefile.inc +++ b/src/drivers/intel/fsp1_1/Makefile.inc @@ -18,7 +18,6 @@ # Foundation, Inc. # -romstage-$(CONFIG_GOP_SUPPORT) += fsp_gop.c romstage-y += fsp_util.c romstage-y += hob.c diff --git a/src/drivers/intel/fsp1_1/fsp_gop.c b/src/drivers/intel/fsp1_1/fsp_gop.c index 32a176f398..ed1f1b4057 100644 --- a/src/drivers/intel/fsp1_1/fsp_gop.c +++ b/src/drivers/intel/fsp1_1/fsp_gop.c @@ -61,7 +61,6 @@ const optionrom_vbt_t *fsp_get_vbt(uint32_t *vbt_len) return vbt.data; } -#if ENV_RAMSTAGE void fsp_gop_framebuffer(struct lb_header *header) { struct lb_framebuffer *framebuffer; @@ -98,4 +97,3 @@ void fsp_gop_framebuffer(struct lb_header *header) framebuffer->tag = LB_TAG_FRAMEBUFFER; framebuffer->size = sizeof(*framebuffer); } -#endif /* ENV_RAMSTAGE */ diff --git a/src/drivers/intel/fsp1_1/fsp_gop.h b/src/drivers/intel/fsp1_1/fsp_gop.h index fc259014e3..2999369e2f 100644 --- a/src/drivers/intel/fsp1_1/fsp_gop.h +++ b/src/drivers/intel/fsp1_1/fsp_gop.h @@ -27,8 +27,7 @@ #include const optionrom_vbt_t *fsp_get_vbt(uint32_t *vbt_len); -#if ENV_RAMSTAGE void fsp_gop_framebuffer(struct lb_header *header); -#endif /* ENV_RAMSTAGE */ + #endif /* CONFIG_GOP_SUPPORT */ #endif /* _FSP_GOP_H_ */ -- cgit v1.2.3