From 0d1734eea4196b9c182023a4547cba07a8a0a8c5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ky=C3=B6sti=20M=C3=A4lkki?= Date: Thu, 15 Dec 2022 22:12:29 +0200 Subject: Drop many cases of CONFIG_MAINBOARD_PART_NUMBER MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We have largely dropped from filling in mainboard_ops.name as unnecessary. A common place should be decided where or if this information is added in the console log. Change-Id: I917222922560c6273b4be91cd7d99ce2ff8e4231 Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/c/coreboot/+/74450 Tested-by: build bot (Jenkins) Reviewed-by: Hung-Te Lin Reviewed-by: Arthur Heymans Reviewed-by: Felix Singer --- src/mainboard/google/cherry/mainboard.c | 1 - src/mainboard/google/corsola/mainboard.c | 1 - src/mainboard/google/geralt/mainboard.c | 1 - src/mainboard/google/guybrush/mainboard.c | 2 -- src/mainboard/google/herobrine/mainboard.c | 1 - src/mainboard/google/myst/mainboard.c | 2 -- src/mainboard/google/skyrim/mainboard.c | 2 -- 7 files changed, 10 deletions(-) (limited to 'src') diff --git a/src/mainboard/google/cherry/mainboard.c b/src/mainboard/google/cherry/mainboard.c index 44478062a3..c1593ca999 100644 --- a/src/mainboard/google/cherry/mainboard.c +++ b/src/mainboard/google/cherry/mainboard.c @@ -159,6 +159,5 @@ static void mainboard_enable(struct device *dev) } struct chip_operations mainboard_ops = { - .name = CONFIG_MAINBOARD_PART_NUMBER, .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/google/corsola/mainboard.c b/src/mainboard/google/corsola/mainboard.c index 3efedf8db8..b6823c671c 100644 --- a/src/mainboard/google/corsola/mainboard.c +++ b/src/mainboard/google/corsola/mainboard.c @@ -58,6 +58,5 @@ static void mainboard_enable(struct device *dev) } struct chip_operations mainboard_ops = { - .name = CONFIG_MAINBOARD_PART_NUMBER, .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/google/geralt/mainboard.c b/src/mainboard/google/geralt/mainboard.c index 1422398342..4042dcefef 100644 --- a/src/mainboard/google/geralt/mainboard.c +++ b/src/mainboard/google/geralt/mainboard.c @@ -69,6 +69,5 @@ static void mainboard_enable(struct device *dev) } struct chip_operations mainboard_ops = { - .name = CONFIG_MAINBOARD_PART_NUMBER, .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/google/guybrush/mainboard.c b/src/mainboard/google/guybrush/mainboard.c index 71d3ec5087..af79a5e795 100644 --- a/src/mainboard/google/guybrush/mainboard.c +++ b/src/mainboard/google/guybrush/mainboard.c @@ -179,8 +179,6 @@ static void mainboard_fill_ssdt(const struct device *dev) static void mainboard_enable(struct device *dev) { - printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n"); - dev->ops->acpi_fill_ssdt = mainboard_fill_ssdt; /* TODO: b/184678786 - Move into espi_config */ diff --git a/src/mainboard/google/herobrine/mainboard.c b/src/mainboard/google/herobrine/mainboard.c index e2c4199287..6b54678b90 100644 --- a/src/mainboard/google/herobrine/mainboard.c +++ b/src/mainboard/google/herobrine/mainboard.c @@ -173,6 +173,5 @@ static void mainboard_enable(struct device *dev) } struct chip_operations mainboard_ops = { - .name = CONFIG_MAINBOARD_PART_NUMBER, .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/google/myst/mainboard.c b/src/mainboard/google/myst/mainboard.c index 390dd4a9b4..36f5bab6ab 100644 --- a/src/mainboard/google/myst/mainboard.c +++ b/src/mainboard/google/myst/mainboard.c @@ -78,8 +78,6 @@ static void mainboard_init(void *chip_info) static void mainboard_enable(struct device *dev) { - printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n"); - /* TODO: b/184678786 - Move into espi_config */ /* Unmask eSPI IRQ 1 (Keyboard) */ pm_write32(PM_ESPI_INTR_CTRL, PM_ESPI_DEV_INTR_MASK & ~(BIT(1))); diff --git a/src/mainboard/google/skyrim/mainboard.c b/src/mainboard/google/skyrim/mainboard.c index 890c6b36c3..125bebbd82 100644 --- a/src/mainboard/google/skyrim/mainboard.c +++ b/src/mainboard/google/skyrim/mainboard.c @@ -89,8 +89,6 @@ static void mainboard_init(void *chip_info) static void mainboard_enable(struct device *dev) { - printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n"); - /* TODO: b/184678786 - Move into espi_config */ /* Unmask eSPI IRQ 1 (Keyboard) */ pm_write32(PM_ESPI_INTR_CTRL, PM_ESPI_DEV_INTR_MASK & ~(BIT(1))); -- cgit v1.2.3