From 5eb75fe55011bc80d9e9ef6dea801830146274ce Mon Sep 17 00:00:00 2001 From: Felix Held Date: Thu, 9 Jul 2020 00:25:58 +0200 Subject: vc/amd/fsp/picasso: add comment on logical lane numbers in descriptor The expected lane numbers in the fsp_pcie_descriptor struct are the logical and not the physical ones. Change-Id: I14166bbd397a9e5f5c5370717e039b9e71cbdb07 Signed-off-by: Felix Held Reviewed-on: https://review.coreboot.org/c/coreboot/+/43311 Reviewed-by: Angel Pons Reviewed-by: Raul Rangel Tested-by: build bot (Jenkins) --- src/vendorcode/amd/fsp/picasso/platform_descriptors.h | 1 + 1 file changed, 1 insertion(+) (limited to 'src/vendorcode') diff --git a/src/vendorcode/amd/fsp/picasso/platform_descriptors.h b/src/vendorcode/amd/fsp/picasso/platform_descriptors.h index cae5d45bd8..9765ea6f2e 100644 --- a/src/vendorcode/amd/fsp/picasso/platform_descriptors.h +++ b/src/vendorcode/amd/fsp/picasso/platform_descriptors.h @@ -110,6 +110,7 @@ typedef struct __packed { } fsp_ddi_descriptor; /* Picasso PCIe Descriptor: used for assigning lanes, bifurcation and other settings */ +/* Beware that the lane numbers in here are the logical and not the physical lane numbers! */ typedef struct __packed { uint8_t engine_type; uint8_t start_lane; // Start lane of the pci device -- cgit v1.2.3