From 16995fb7eacf3a2b946795ab327c3c1764ab81ca Mon Sep 17 00:00:00 2001 From: Martin Roth Date: Fri, 10 Nov 2017 20:28:44 -0700 Subject: vendorcode/amd/pi/00670f00: Set ModuleIdentifier to be 8 bytes ModuleIdentifier must be 8 bytes. Every other location else that uses this value explicityly defines it as 8 bytes. If it's initialized here to less than 8 bytes, it gets passed to those other locations with garbage at the end and fails to load the AGESA binary. TEST=Build & boot Kahlee BUG=B:69165234 Change-Id: I11fc90748f49782e2b16ee5326aee17cfe92d0bc Signed-off-by: Martin Roth Reviewed-on: https://review.coreboot.org/22430 Tested-by: build bot (Jenkins) Reviewed-by: Justin TerAvest Reviewed-by: Aaron Durbin --- src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/vendorcode') diff --git a/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c b/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c index 5a41897ff2..ec414b4724 100644 --- a/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c +++ b/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c @@ -53,7 +53,7 @@ CONST UINT32 ImageSignature = IMAGE_SIGNATURE; CONST UINT32 ModuleSignature = MODULE_SIGNATURE; -CONST CHAR8 ModuleIdentifier[] = AGESA_ID; +CONST CHAR8 ModuleIdentifier[8] = AGESA_ID; /********************************************************************** * Interface call: AmdCreateStruct -- cgit v1.2.3