From 583e0522f14fde040f48d2444099e4dededfa185 Mon Sep 17 00:00:00 2001 From: Kyösti Mälkki Date: Mon, 9 Oct 2017 05:29:30 +0300 Subject: binaryPI vendorcode: Remove HeapXXBuffer functions MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The HeapAllocateBuffer and HeapDeallocateBuffer functions are not used. Change-Id: I491a796d87afd0e37051f9caabfff3f70d4d803c Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/22069 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Stefan Reinauer --- src/vendorcode/amd/pi/00630F01/binaryPI/AGESA.c | 59 ------------------------ src/vendorcode/amd/pi/00660F01/binaryPI/AGESA.c | 60 ------------------------- src/vendorcode/amd/pi/00730F01/binaryPI/AGESA.c | 60 ------------------------- 3 files changed, 179 deletions(-) (limited to 'src/vendorcode/amd') diff --git a/src/vendorcode/amd/pi/00630F01/binaryPI/AGESA.c b/src/vendorcode/amd/pi/00630F01/binaryPI/AGESA.c index 52cf3960c7..2bc939970f 100644 --- a/src/vendorcode/amd/pi/00630F01/binaryPI/AGESA.c +++ b/src/vendorcode/amd/pi/00630F01/binaryPI/AGESA.c @@ -50,18 +50,6 @@ #include #include -AGESA_STATUS -HeapAllocateBuffer ( - IN OUT VOID *AllocateHeapParams, - IN OUT VOID *StdHeader - ); - -AGESA_STATUS -HeapDeallocateBuffer ( - IN UINT32 BufferHandle, - IN VOID *StdHeader - ); - CONST UINT32 ImageSignature = IMAGE_SIGNATURE; CONST UINT32 ModuleSignature = MODULE_SIGNATURE; CONST CHAR8 ModuleIdentifier[] = AGESA_ID; @@ -524,53 +512,6 @@ ImcIdle ( ((FCH_DATA_BLOCK*)FchDataPtr)->StdHeader->Func = 0; } -// TODO This has to be removed -AGESA_STATUS -HeapAllocateBuffer ( - IN OUT VOID *AllocateHeapParams, - IN OUT VOID *StdHeader - ) -{ - MODULE_ENTRY Dispatcher = NULL; - const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier); - - AMD_INTERFACE_PARAMS InterfaceParams = {}; - - if (!module) return AGESA_UNSUPPORTED; - Dispatcher = module->ModuleDispatcher; - - InterfaceParams.StdHeader = *(AMD_CONFIG_PARAMS*)StdHeader; - InterfaceParams.StdHeader.Func = AMD_HEAP_ALLOCATE_BUFFER; - - InterfaceParams.AllocationMethod = PreMemHeap; - InterfaceParams.NewStructPtr = AllocateHeapParams; - - return Dispatcher(&InterfaceParams); -} - -// TODO This has to be removed -AGESA_STATUS -HeapDeallocateBuffer ( - IN UINT32 BufferHandle, - IN VOID *StdHeader - ) -{ - MODULE_ENTRY Dispatcher = NULL; - const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier); - - AMD_INTERFACE_PARAMS InterfaceParams = {}; - - if (!module) return AGESA_UNSUPPORTED; - Dispatcher = module->ModuleDispatcher; - - InterfaceParams.StdHeader = *(AMD_CONFIG_PARAMS*)StdHeader; - InterfaceParams.StdHeader.Func = AMD_HEAP_DEALLOCATE_BUFFER; - - InterfaceParams.NewStructPtr = &BufferHandle; - - return Dispatcher(&InterfaceParams); -} - /********************************************************************** * Interface call: AmdSetValue **********************************************************************/ diff --git a/src/vendorcode/amd/pi/00660F01/binaryPI/AGESA.c b/src/vendorcode/amd/pi/00660F01/binaryPI/AGESA.c index 405a45075d..cb2f7f69f5 100644 --- a/src/vendorcode/amd/pi/00660F01/binaryPI/AGESA.c +++ b/src/vendorcode/amd/pi/00660F01/binaryPI/AGESA.c @@ -52,19 +52,6 @@ #include #include -// TODO These need to be replaced with calls to CreateStruct() -AGESA_STATUS -HeapAllocateBuffer ( - IN OUT VOID *AllocateHeapParams, - IN OUT VOID *StdHeader - ); - -AGESA_STATUS -HeapDeallocateBuffer ( - IN UINT32 BufferHandle, - IN VOID *StdHeader - ); - CONST UINT32 ImageSignature = IMAGE_SIGNATURE; CONST UINT32 ModuleSignature = MODULE_SIGNATURE; CONST CHAR8 ModuleIdentifier[] = AGESA_ID; @@ -415,53 +402,6 @@ FchInitS3LateRestore ( Dispatcher(FchDataPtr); } -// TODO This has to be removed -AGESA_STATUS -HeapAllocateBuffer ( - IN OUT VOID *AllocateHeapParams, - IN OUT VOID *StdHeader - ) -{ - MODULE_ENTRY Dispatcher = NULL; - const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier); - - AMD_INTERFACE_PARAMS InterfaceParams = {}; - - if (!module) return AGESA_UNSUPPORTED; - Dispatcher = module->ModuleDispatcher; - - InterfaceParams.StdHeader = *(AMD_CONFIG_PARAMS*)StdHeader; - InterfaceParams.StdHeader.Func = AMD_HEAP_ALLOCATE_BUFFER; - - InterfaceParams.AllocationMethod = PreMemHeap; - InterfaceParams.NewStructPtr = AllocateHeapParams; - - return Dispatcher(&InterfaceParams); -} - -// TODO This has to be removed -AGESA_STATUS -HeapDeallocateBuffer ( - IN UINT32 BufferHandle, - IN VOID *StdHeader - ) -{ - MODULE_ENTRY Dispatcher = NULL; - const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier); - - AMD_INTERFACE_PARAMS InterfaceParams = {}; - - if (!module) return AGESA_UNSUPPORTED; - Dispatcher = module->ModuleDispatcher; - - InterfaceParams.StdHeader = *(AMD_CONFIG_PARAMS*)StdHeader; - InterfaceParams.StdHeader.Func = AMD_HEAP_DEALLOCATE_BUFFER; - - InterfaceParams.NewStructPtr = &BufferHandle; - - return Dispatcher(&InterfaceParams); -} - /********************************************************************** * Interface call: AmdSetValue **********************************************************************/ diff --git a/src/vendorcode/amd/pi/00730F01/binaryPI/AGESA.c b/src/vendorcode/amd/pi/00730F01/binaryPI/AGESA.c index 25364d859f..f233542863 100644 --- a/src/vendorcode/amd/pi/00730F01/binaryPI/AGESA.c +++ b/src/vendorcode/amd/pi/00730F01/binaryPI/AGESA.c @@ -49,19 +49,6 @@ #include "FchDef.h" #include "amdlib.h" -// TODO These need to be replaced with calls to CreateStruct() -AGESA_STATUS -HeapAllocateBuffer ( - IN OUT VOID *AllocateHeapParams, - IN OUT VOID *StdHeader - ); - -AGESA_STATUS -HeapDeallocateBuffer ( - IN UINT32 BufferHandle, - IN VOID *StdHeader - ); - CONST UINT32 ImageSignature = IMAGE_SIGNATURE; CONST UINT32 ModuleSignature = MODULE_SIGNATURE; CONST CHAR8 ModuleIdentifier[] = AGESA_ID; @@ -524,53 +511,6 @@ ImcIdle ( ((FCH_DATA_BLOCK*)FchDataPtr)->StdHeader->Func = 0; } -// TODO This has to be removed -AGESA_STATUS -HeapAllocateBuffer ( - IN OUT VOID *AllocateHeapParams, - IN OUT VOID *StdHeader - ) -{ - MODULE_ENTRY Dispatcher = NULL; - const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier); - - AMD_INTERFACE_PARAMS InterfaceParams = {}; - - if (!module) return AGESA_UNSUPPORTED; - Dispatcher = module->ModuleDispatcher; - - InterfaceParams.StdHeader = *(AMD_CONFIG_PARAMS*)StdHeader; - InterfaceParams.StdHeader.Func = AMD_HEAP_ALLOCATE_BUFFER; - - InterfaceParams.AllocationMethod = PreMemHeap; - InterfaceParams.NewStructPtr = AllocateHeapParams; - - return Dispatcher(&InterfaceParams); -} - -// TODO This has to be removed -AGESA_STATUS -HeapDeallocateBuffer ( - IN UINT32 BufferHandle, - IN VOID *StdHeader - ) -{ - MODULE_ENTRY Dispatcher = NULL; - const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier); - - AMD_INTERFACE_PARAMS InterfaceParams = {}; - - if (!module) return AGESA_UNSUPPORTED; - Dispatcher = module->ModuleDispatcher; - - InterfaceParams.StdHeader = *(AMD_CONFIG_PARAMS*)StdHeader; - InterfaceParams.StdHeader.Func = AMD_HEAP_DEALLOCATE_BUFFER; - - InterfaceParams.NewStructPtr = &BufferHandle; - - return Dispatcher(&InterfaceParams); -} - /********************************************************************** * Interface call: AmdSetValue **********************************************************************/ -- cgit v1.2.3