From 86ee4db0d89dfd53a4e153db8e89888a0c762e3e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ky=C3=B6sti=20M=C3=A4lkki?= Date: Wed, 22 Jun 2016 22:50:10 +0300 Subject: AGESA: Use printk for IDS output MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In all simplicity, with board/OptionsIds.h file having: IDSOPT_IDS_ENABLED TRUE IDSOPT_TRACING_ENABLED TRUE And src/Kconfig modified to: config WARNINGS_ARE_ERRORS default n With these settings AGESA outputs complete debugging log where-ever you have your coreboot console configured. Change-Id: Ie5c0de6358b294160f9bf0a202161722f88059c1 Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/15320 Reviewed-by: Marshall Dawson Tested-by: build bot (Jenkins) --- src/vendorcode/amd/agesa/f15/Include/Ids.h | 29 +++++------------------------ 1 file changed, 5 insertions(+), 24 deletions(-) (limited to 'src/vendorcode/amd/agesa/f15/Include') diff --git a/src/vendorcode/amd/agesa/f15/Include/Ids.h b/src/vendorcode/amd/agesa/f15/Include/Ids.h index 07ceeaf603..e980688711 100644 --- a/src/vendorcode/amd/agesa/f15/Include/Ids.h +++ b/src/vendorcode/amd/agesa/f15/Include/Ids.h @@ -530,30 +530,11 @@ typedef enum { //vv- for debug reference only #define IDS_HDT_CONSOLE_S3_EXIT(x) #define IDS_HDT_CONSOLE_S3_AP_EXIT(x) - #ifdef __GNUC__ - #if CONFIG_REDIRECT_IDS_HDT_CONSOLE_TO_SERIAL - /* print all*/ - //#define IDS_HDT_CONSOLE(f, s, args...) do {do_printk(BIOS_DEBUG, s, ##args);} while (0) - #define IDS_HDT_CONSOLE(f, s, args...) do {\ - if (f == MAIN_FLOW) {\ - do_printk(BIOS_DEBUG, s, ##args);\ - } else if (f == MEM_FLOW) {\ - do_printk(BIOS_DEBUG, s, ##args);\ - } else if (f == CPU_TRACE) {\ - do_printk(BIOS_DEBUG, s, ##args);\ - } else if (f == HT_TRACE) {\ - do_printk(BIOS_DEBUG, s, ##args);\ - } else if (f == GNB_TRACE) {\ - do_printk(BIOS_DEBUG, s, ##args);\ - } else if (f == FCH_TRACE) {\ - do_printk(BIOS_DEBUG, s, ##args);\ - }\ - } while(0) - #else - #define IDS_HDT_CONSOLE(s, args...) do {} while(0) - #endif - #else - #define IDS_HDT_CONSOLE(s, args...) + #ifndef __GNUC__ + #pragma warning(disable: 4127) + #define IDS_HDT_CONSOLE(f, s, ...) + #else + #define IDS_HDT_CONSOLE(f, s, ...) printk (BIOS_DEBUG, s, ##__VA_ARGS__); #endif #define IDS_HDT_CONSOLE_FLUSH_BUFFER(x) -- cgit v1.2.3