From 5de5522685c260e9643bad14faa22d417e3fc662 Mon Sep 17 00:00:00 2001 From: Edward O'Callaghan Date: Wed, 14 Jan 2015 00:41:44 +1100 Subject: vendorcode/amd/agesa: Fix tautological compare An unsigned enum expression is always strictly positive; Comparison with '>= 0' is a tautology, hence remove it. Change-Id: I910d672f8a27d278c2a2fe1e4f39fc61f2c5dbc5 Signed-off-by: Edward O'Callaghan Reviewed-on: https://review.coreboot.org/8207 Reviewed-by: Stefan Reinauer Tested-by: build bot (Jenkins) --- src/vendorcode/amd/agesa/f12/Proc/Mem/NB/HY/mnreghy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/vendorcode/amd/agesa/f12/Proc/Mem/NB/HY') diff --git a/src/vendorcode/amd/agesa/f12/Proc/Mem/NB/HY/mnreghy.c b/src/vendorcode/amd/agesa/f12/Proc/Mem/NB/HY/mnreghy.c index 04b6912215..8f59d4d79f 100644 --- a/src/vendorcode/amd/agesa/f12/Proc/Mem/NB/HY/mnreghy.c +++ b/src/vendorcode/amd/agesa/f12/Proc/Mem/NB/HY/mnreghy.c @@ -173,7 +173,7 @@ MemNCmnGetSetFieldHy ( UINT32 Mask; Value = 0; - if ((FieldName < BFEndOfList) && (FieldName >= 0)) { + if (FieldName < BFEndOfList) { Address = NBPtr->NBRegTable[FieldName]; if (Address) { Lowbit = TSEFO_END (Address); -- cgit v1.2.3