From 959cab4f1fd10901e64f2865fde240689201587c Mon Sep 17 00:00:00 2001 From: Julius Werner Date: Mon, 17 Jul 2017 17:47:31 -0700 Subject: vboot: Remove get_sw_write_protect_state callback We've just decided to remove the only known use of the VBSD_SW_WP flag in vboot (https://chromium-review.googlesource.com/c/575389), since it was unused and never reliable on all platforms anyway. Therefore, we can now also remove the coreboot infrastructure that supported it. It doesn't really hurt anyone, but removing it saves a small bit of effort for future platforms. Change-Id: I6706eba2761a73482e03f3bf46343cf1d84f154b Signed-off-by: Julius Werner Reviewed-on: https://review.coreboot.org/20628 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Aaron Durbin --- src/vboot/bootmode.c | 6 ------ src/vboot/vboot_handoff.c | 2 -- 2 files changed, 8 deletions(-) (limited to 'src/vboot') diff --git a/src/vboot/bootmode.c b/src/vboot/bootmode.c index 23dec13396..120744837b 100644 --- a/src/vboot/bootmode.c +++ b/src/vboot/bootmode.c @@ -147,12 +147,6 @@ int __attribute__((weak)) clear_recovery_mode_switch(void) return 0; } -int __attribute__((weak)) get_sw_write_protect_state(void) -{ - // Can be implemented by a platform / mainboard - return 0; -} - void __attribute__((weak)) log_recovery_mode_switch(void) { // Weak implementation. Nothing to do. diff --git a/src/vboot/vboot_handoff.c b/src/vboot/vboot_handoff.c index b3a5c19641..64c8ca6ef7 100644 --- a/src/vboot/vboot_handoff.c +++ b/src/vboot/vboot_handoff.c @@ -62,8 +62,6 @@ static void fill_vboot_handoff(struct vboot_handoff *vboot_handoff, if (get_write_protect_state()) vb_sd->flags |= VBSD_BOOT_FIRMWARE_WP_ENABLED; - if (get_sw_write_protect_state()) - vb_sd->flags |= VBSD_BOOT_FIRMWARE_SW_WP_ENABLED; if (vb2_sd->recovery_reason) { vb_sd->firmware_index = 0xFF; -- cgit v1.2.3