From ffe460d77ab5bcbdbaeef095f807dd0fdbefd42c Mon Sep 17 00:00:00 2001 From: Edward O'Callaghan Date: Sun, 27 Apr 2014 22:51:40 +1000 Subject: superio/winbond/w83627dhg: Convert romstage to generic component MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Convert the serial init to the generic romstage component and corresponding boards using this sio. Change-Id: I36bcf38c4351130be1ed924ecfe606336d0433f3 Signed-off-by: Edward O'Callaghan Reviewed-on: http://review.coreboot.org/5588 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Kyösti Mälkki --- src/superio/winbond/w83627dhg/early_serial.c | 10 ---------- src/superio/winbond/w83627dhg/w83627dhg.h | 7 +++---- 2 files changed, 3 insertions(+), 14 deletions(-) (limited to 'src/superio') diff --git a/src/superio/winbond/w83627dhg/early_serial.c b/src/superio/winbond/w83627dhg/early_serial.c index ec9e81e00a..67aaa93343 100644 --- a/src/superio/winbond/w83627dhg/early_serial.c +++ b/src/superio/winbond/w83627dhg/early_serial.c @@ -37,16 +37,6 @@ void pnp_exit_ext_func_mode(device_t dev) outb(0xaa, port); } -void w83627dhg_enable_serial(device_t dev, u16 iobase) -{ - pnp_enter_ext_func_mode(dev); - pnp_set_logical_device(dev); - pnp_set_enable(dev, 0); - pnp_set_iobase(dev, PNP_IDX_IO0, iobase); - pnp_set_enable(dev, 1); - pnp_exit_ext_func_mode(dev); -} - /** * Select Pin 89, Pin 90 function as I2C interface SDA, SCL. * {Pin 89, Pin 90} function can be selected as {GP33, GP32}, or diff --git a/src/superio/winbond/w83627dhg/w83627dhg.h b/src/superio/winbond/w83627dhg/w83627dhg.h index 9e83d34c44..08ea04fa2a 100644 --- a/src/superio/winbond/w83627dhg/w83627dhg.h +++ b/src/superio/winbond/w83627dhg/w83627dhg.h @@ -19,8 +19,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ -#ifndef SUPERIO_WINBOND_W83627DHG_W83627DHG_H -#define SUPERIO_WINBOND_W83627DHG_W83627DHG_H +#ifndef SUPERIO_WINBOND_W83627DHG_H +#define SUPERIO_WINBOND_W83627DHG_H #define W83627DHG_FDC 0 /* Floppy */ #define W83627DHG_PP 1 /* Parallel port */ @@ -54,8 +54,7 @@ void pnp_enter_ext_func_mode(device_t dev); void pnp_exit_ext_func_mode(device_t dev); -void w83627dhg_enable_serial(device_t dev, u16 iobase); void w83627dhg_enable_i2c(device_t dev); void w83627dhg_set_clksel_48(device_t dev); -#endif +#endif /* SUPERIO_WINBOND_W83627DHG_H */ -- cgit v1.2.3