From 78fa372ec9f7e26b8af715a90d44fb537bbd4425 Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Thu, 20 Jun 2019 20:12:40 +0200 Subject: superio/nuvoton/nct6791d: Add symbol to select COM port Like the NCT6776, the NCT6791D has muxed COMA/GPIO8 functions. Since it requires setting different bits, add a new Kconfig symbol to do it. Change-Id: I62dc18810026f9b1550da19950f66af605600ec8 Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/33640 Tested-by: build bot (Jenkins) Reviewed-by: Maxim Polyakov Reviewed-by: Felix Held --- src/superio/nuvoton/common/early_serial.c | 6 ++++++ src/superio/nuvoton/nct6791d/Kconfig | 5 +++++ 2 files changed, 11 insertions(+) (limited to 'src/superio') diff --git a/src/superio/nuvoton/common/early_serial.c b/src/superio/nuvoton/common/early_serial.c index b35ec9d8b9..7f22993cd0 100644 --- a/src/superio/nuvoton/common/early_serial.c +++ b/src/superio/nuvoton/common/early_serial.c @@ -64,9 +64,15 @@ void nuvoton_pnp_exit_conf_state(pnp_devfn_t dev) void nuvoton_enable_serial(pnp_devfn_t dev, u16 iobase) { nuvoton_pnp_enter_conf_state(dev); + if (CONFIG(SUPERIO_NUVOTON_NCT6776_COM_A)) /* Route GPIO8 pin group to COM A */ pnp_write_config(dev, 0x2a, 0x40); + + if (CONFIG(SUPERIO_NUVOTON_NCT6791D_COM_A)) + /* Route GPIO8 pin group to COM A */ + pnp_write_config(dev, 0x2a, 0x00); + pnp_set_logical_device(dev); pnp_set_enable(dev, 0); pnp_set_iobase(dev, PNP_IDX_IO0, iobase); diff --git a/src/superio/nuvoton/nct6791d/Kconfig b/src/superio/nuvoton/nct6791d/Kconfig index 6e39e462aa..55581fbcfe 100644 --- a/src/superio/nuvoton/nct6791d/Kconfig +++ b/src/superio/nuvoton/nct6791d/Kconfig @@ -16,3 +16,8 @@ config SUPERIO_NUVOTON_NCT6791D bool select SUPERIO_NUVOTON_COMMON_PRE_RAM + +config SUPERIO_NUVOTON_NCT6791D_COM_A + bool + depends on SUPERIO_NUVOTON_NCT6791D + default n -- cgit v1.2.3