From a2f4758900dcfbebf54447acea2aeee678c5f018 Mon Sep 17 00:00:00 2001 From: Martin Roth Date: Wed, 13 Apr 2016 12:20:52 -0600 Subject: superio/smsc/mec1308: Fix AddressMax value for SMBX mailbox The way this was implemented before was causing ACPI failures. There was also a basic misunderstanding of what the AddressMax field was used for. In this case, because it's a fixed address, it should be the same as the AddressMin field. Getting rid of the addition in the field solves the ACPI output problem. Change-Id: Idec2bf0ed27ae694e98f141087cdf22401937178 Signed-off-by: Martin Roth Reviewed-on: https://review.coreboot.org/14343 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer Reviewed-by: Idwer Vollering Reviewed-by: Duncan Laurie --- src/superio/smsc/mec1308/acpi/superio.asl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/superio/smsc') diff --git a/src/superio/smsc/mec1308/acpi/superio.asl b/src/superio/smsc/mec1308/acpi/superio.asl index 6794448766..cc174f96ae 100644 --- a/src/superio/smsc/mec1308/acpi/superio.asl +++ b/src/superio/smsc/mec1308/acpi/superio.asl @@ -246,12 +246,12 @@ Device (SIO) { Name (_CRS, ResourceTemplate() { - IO (Decode16, SIO_SMBX_IO0, SIO_SMBX_IO0 + 0x34, 0x01, 0x34) + IO (Decode16, SIO_SMBX_IO0, SIO_SMBX_IO0, 0x01, 0x34) }) Name (_PRS, ResourceTemplate() { - IO (Decode16, SIO_SMBX_IO0, SIO_SMBX_IO0 + 0x34, 0x01, 0x34) + IO (Decode16, SIO_SMBX_IO0, SIO_SMBX_IO0, 0x01, 0x34) }) } #endif -- cgit v1.2.3