From 0b2ee9391079a5092eb99dce764e3836eeb92cd9 Mon Sep 17 00:00:00 2001 From: Nico Huber Date: Sat, 15 Jun 2013 19:58:35 +0200 Subject: pnp: Remove now plain wrappers for default PnP functions After removing the enter()/exit() functions for configuration mode, most wrappers for our standard PnP functions just call the underlying default implementation. Remove those with a little cocci: @ op_match @ identifier op; identifier pnp_op =~ "^pnp_((alt_|)enable|(set|enable)_resources)$"; type device_t; identifier dev; @@ static void op(device_t dev) { pnp_op(dev); } @@ identifier op_match.op; @@ -op(...) {...} /* Three rules to match the alignment, hmmp... */ @@ identifier op_match.op, op_match.pnp_op; identifier ops; @@ struct device_operations ops = { - .set_resources = op, + .set_resources = pnp_op, }; @@ identifier op_match.op, op_match.pnp_op; identifier ops; @@ struct device_operations ops = { - .enable_resources = op, + .enable_resources = pnp_op, }; @@ identifier op_match.op, op_match.pnp_op; identifier ops; @@ struct device_operations ops = { - .enable = op, + .enable = pnp_op, }; Change-Id: Idc0e52c7e3600a01f3b6a4e17763557b271b481e Signed-off-by: Nico Huber Reviewed-on: http://review.coreboot.org/3483 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Marc Jones Reviewed-by: Stefan Reinauer --- src/superio/smsc/smscsuperio/superio.c | 29 +++-------------------------- 1 file changed, 3 insertions(+), 26 deletions(-) (limited to 'src/superio/smsc/smscsuperio') diff --git a/src/superio/smsc/smscsuperio/superio.c b/src/superio/smsc/smscsuperio/superio.c index 9af67a1c02..d45a9671c1 100644 --- a/src/superio/smsc/smscsuperio/superio.c +++ b/src/superio/smsc/smscsuperio/superio.c @@ -169,29 +169,6 @@ static void smsc_pnp_exit_conf_state(device_t dev) outb(0xaa, dev->path.pnp.port); } -/** Wrapper for pnp_set_resources(). */ -static void smsc_pnp_set_resources(device_t dev) -{ - pnp_set_resources(dev); -} - -/** Wrapper for pnp_enable_resources(). */ -static void smsc_pnp_enable_resources(device_t dev) -{ - pnp_enable_resources(dev); -} - -/** - * If so configured, enable the specified device, otherwise - * explicitly disable it. - * - * @param dev The device to use. - */ -static void smsc_pnp_enable(device_t dev) -{ - pnp_alt_enable(dev); -} - /** * Initialize those logical devices which need a special init. * @@ -230,9 +207,9 @@ static const struct pnp_mode_ops pnp_conf_mode_ops = { /** Standard device operations. */ static struct device_operations ops = { .read_resources = pnp_read_resources, - .set_resources = smsc_pnp_set_resources, - .enable_resources = smsc_pnp_enable_resources, - .enable = smsc_pnp_enable, + .set_resources = pnp_set_resources, + .enable_resources = pnp_enable_resources, + .enable = pnp_alt_enable, .init = smsc_init, .ops_pnp_mode = &pnp_conf_mode_ops, }; -- cgit v1.2.3