From bfb11bec3b3fec638adf864a9b9b2cff6671fed8 Mon Sep 17 00:00:00 2001 From: Nicholas Sudsgaard Date: Tue, 30 Jan 2024 09:53:46 +0900 Subject: include/device/device.h: Remove CHIP_NAME() macro Macros can be confusing on their own; hiding commas make things worse. This can sometimes be downright misleading. A "good" example would be the code in soc/intel/xeon_sp/spr/chip.c: CHIP_NAME("Intel SapphireRapids-SP").enable_dev = chip_enable_dev, This appears as CHIP_NAME() being some struct when in fact these are defining 2 separate members of the same struct. It was decided to remove this macro altogether, as it does not do anything special and incurs a maintenance burden. Change-Id: Iaed6dfb144bddcf5c43634b0c955c19afce388f0 Signed-off-by: Nicholas Sudsgaard Reviewed-on: https://review.coreboot.org/c/coreboot/+/80239 Reviewed-by: Yidi Lin Reviewed-by: Felix Singer Reviewed-by: Jakub Czapiga Tested-by: build bot (Jenkins) Reviewed-by: Matt DeVillier --- src/superio/nsc/pc87392/superio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/superio/nsc/pc87392') diff --git a/src/superio/nsc/pc87392/superio.c b/src/superio/nsc/pc87392/superio.c index e65afeab6e..551249d78f 100644 --- a/src/superio/nsc/pc87392/superio.c +++ b/src/superio/nsc/pc87392/superio.c @@ -35,6 +35,6 @@ static void enable_dev(struct device *dev) } struct chip_operations superio_nsc_pc87392_ops = { - CHIP_NAME("NSC PC87392 Super I/O") + .name = "NSC PC87392 Super I/O", .enable_dev = enable_dev, }; -- cgit v1.2.3