From faca0bc2fa5a347a98fc3ee8dd1a5dd9c9763459 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Wed, 27 Dec 2017 22:51:29 +0100 Subject: superio/nsc: pass the chip-specific ops struct to pnp_enable_devices Pass the address of the chip-specific ops struct instead of the one of the generic pnp_ops struct to the PNP device enable function. This allows the removal of the LDN-specific ops overrides which is also done in this patch. Change-Id: I0c820254e97e3f80470d148552af06940e147b74 Signed-off-by: Felix Held Reviewed-on: https://review.coreboot.org/23008 Tested-by: build bot (Jenkins) Reviewed-by: Arthur Heymans --- src/superio/nsc/pc87384/superio.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) (limited to 'src/superio/nsc/pc87384') diff --git a/src/superio/nsc/pc87384/superio.c b/src/superio/nsc/pc87384/superio.c index bd59a5b7a0..a24e1b65cf 100644 --- a/src/superio/nsc/pc87384/superio.c +++ b/src/superio/nsc/pc87384/superio.c @@ -31,16 +31,15 @@ static struct device_operations ops = { }; static struct pnp_info pnp_dev_info[] = { - { &ops, PC87384_PP, PNP_IO0 | PNP_IRQ0 | PNP_DRQ0, 0x04f8 }, - { &ops, PC87384_SP1, PNP_IO0 | PNP_IRQ0, 0x07f8 }, - { &ops, PC87384_SP2, PNP_IO0 | PNP_IRQ0, 0x07f8 }, - { &ops, PC87384_GPIO, PNP_IO0 | PNP_IRQ0, 0xfff0 }, + { NULL, PC87384_PP, PNP_IO0 | PNP_IRQ0 | PNP_DRQ0, 0x04f8 }, + { NULL, PC87384_SP1, PNP_IO0 | PNP_IRQ0, 0x07f8 }, + { NULL, PC87384_SP2, PNP_IO0 | PNP_IRQ0, 0x07f8 }, + { NULL, PC87384_GPIO, PNP_IO0 | PNP_IRQ0, 0xfff0 }, }; static void enable_dev(struct device *dev) { - pnp_enable_devices(dev, &pnp_ops, - ARRAY_SIZE(pnp_dev_info), pnp_dev_info); + pnp_enable_devices(dev, &ops, ARRAY_SIZE(pnp_dev_info), pnp_dev_info); } struct chip_operations superio_nsc_pc87384_ops = { -- cgit v1.2.3