From 74d8ed0cb8c659ec65b509bc32882e194168a891 Mon Sep 17 00:00:00 2001 From: Keith Hui Date: Mon, 16 Oct 2017 17:14:25 -0400 Subject: superio/acpi/pnp.asl: Fix PNP_READ_DMA/PNP_WRITE_DMA macros These macros, broken since day one, should CreateByteField instead of CreateWordField. Without the fix, any ASLs that try to use it will fail to compile with a "ResourceTag smaller than Field" warning. Change-Id: Ieeb509aece8836785998b23fdc805a747d40a77a Signed-off-by: Keith Hui Reviewed-on: https://review.coreboot.org/22066 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth Reviewed-by: Paul Menzel --- src/superio/acpi/pnp.asl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/superio/acpi/pnp.asl') diff --git a/src/superio/acpi/pnp.asl b/src/superio/acpi/pnp.asl index 114dfe993d..c5aba6dadf 100644 --- a/src/superio/acpi/pnp.asl +++ b/src/superio/acpi/pnp.asl @@ -124,7 +124,7 @@ ShiftLeft (One, IRQ_FROM, IRQ_TAG##W) #define PNP_READ_DMA(DMA_FROM, RESOURCE_TEMPLATE, DMA_TAG) \ - CreateWordField (RESOURCE_TEMPLATE, DMA_TAG._DMA, DMA_TAG##W)\ + CreateByteField (RESOURCE_TEMPLATE, DMA_TAG._DMA, DMA_TAG##W)\ ShiftLeft (One, DMA_FROM, DMA_TAG##W) #define PNP_WRITE_IO(IO_TO, RESOURCE, IO_TAG) \ @@ -137,7 +137,7 @@ Subtract (FindSetLeftBit (IRQ_TAG##W), 1, IRQ_TO) #define PNP_WRITE_DMA(DMA_TO, RESOURCE, DMA_TAG) \ - CreateWordField (RESOURCE, DMA_TAG._DMA, DMA_TAG##W)\ + CreateByteField (RESOURCE, DMA_TAG._DMA, DMA_TAG##W)\ Subtract (FindSetLeftBit (DMA_TAG##W), 1, DMA_TO) #endif -- cgit v1.2.3