From d6319e8cc08995564d9834a654c78c3d5e111822 Mon Sep 17 00:00:00 2001 From: Timothy Pearson Date: Mon, 1 Aug 2016 16:04:12 -0500 Subject: sb/amd/sb[6|7|8]00: Initialize PIC MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The PIC was not initialized, leading to hangs when booting Linux as a payload. This error was hidden by both SeaBIOS and GRUB due to both payloads initializing the PIC as a matter of routine. Change-Id: I9a3b9bd831d4dafdd0bb82ea023026a10fe7efca Signed-off-by: Timothy Pearson Reviewed-on: https://review.coreboot.org/16018 Tested-by: build bot (Jenkins) Reviewed-by: Kyösti Mälkki Reviewed-by: Paul Menzel Reviewed-by: Ronald G. Minnich Reviewed-by: Patrick Georgi Tested-by: Raptor Engineering Automated Test Stand --- src/southbridge/amd/sb600/lpc.c | 5 +++++ src/southbridge/amd/sb700/lpc.c | 5 +++++ src/southbridge/amd/sb800/lpc.c | 5 +++++ 3 files changed, 15 insertions(+) (limited to 'src/southbridge') diff --git a/src/southbridge/amd/sb600/lpc.c b/src/southbridge/amd/sb600/lpc.c index d459b1d3fd..0541518ca1 100644 --- a/src/southbridge/amd/sb600/lpc.c +++ b/src/southbridge/amd/sb600/lpc.c @@ -20,6 +20,8 @@ #include #include #include +#include +#include #include #include #include @@ -60,6 +62,9 @@ static void lpc_init(device_t dev) pci_write_config8(dev, 0x78, byte); cmos_check_update_date(); + + setup_i8259(); /* Initialize i8259 pic */ + setup_i8254(); /* Initialize i8254 timers */ } static void sb600_lpc_read_resources(device_t dev) diff --git a/src/southbridge/amd/sb700/lpc.c b/src/southbridge/amd/sb700/lpc.c index 78933fadf4..f138d88d72 100644 --- a/src/southbridge/amd/sb700/lpc.c +++ b/src/southbridge/amd/sb700/lpc.c @@ -21,6 +21,8 @@ #include #include #include +#include +#include #include #include #include @@ -75,6 +77,9 @@ static void lpc_init(device_t dev) pci_write_config8(dev, 0x78, byte); cmos_check_update_date(); + + setup_i8259(); /* Initialize i8259 pic */ + setup_i8254(); /* Initialize i8254 timers */ } #if IS_ENABLED(CONFIG_LATE_CBMEM_INIT) diff --git a/src/southbridge/amd/sb800/lpc.c b/src/southbridge/amd/sb800/lpc.c index 3ba47a077b..f15fed366a 100644 --- a/src/southbridge/amd/sb800/lpc.c +++ b/src/southbridge/amd/sb800/lpc.c @@ -21,6 +21,8 @@ #include #include #include +#include +#include #include #include #include @@ -66,6 +68,9 @@ static void lpc_init(device_t dev) pci_write_config8(dev, 0xBB, byte); cmos_check_update_date(); + + setup_i8259(); /* Initialize i8259 pic */ + setup_i8254(); /* Initialize i8254 timers */ } static void sb800_lpc_read_resources(device_t dev) -- cgit v1.2.3