From d441afda9106d000ff1d518bad01e98cfb26630e Mon Sep 17 00:00:00 2001 From: Tobias Diedrich Date: Sun, 14 Nov 2010 14:12:14 +0000 Subject: Currently the cablesel |= (sb->ide0_80pin_cable << 28) | (sb->ide0_80pin_cable << 20) | (sb->ide1_80pin_cable << 12) | (sb->ide1_80pin_cable << 4); in vt8237r_ide.c ends up doing cablesel |= 0xfffffff0; (with both bits set to 1) which is probably not the intended result. ;) After a short discussion on irc the consensus was to change the bitfields to u8 as it's probably not worth it using bitfields here. Signed-off-by: Tobias Diedrich Acked-by: Rudolf Marek git-svn-id: svn://svn.coreboot.org/coreboot/trunk@6068 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1 --- src/southbridge/via/vt8237r/chip.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'src/southbridge') diff --git a/src/southbridge/via/vt8237r/chip.h b/src/southbridge/via/vt8237r/chip.h index 6f8e4b06d2..f05d3c0bde 100644 --- a/src/southbridge/via/vt8237r/chip.h +++ b/src/southbridge/via/vt8237r/chip.h @@ -50,12 +50,12 @@ struct southbridge_via_vt8237r_config { */ u16 fn_ctrl_hi; - int ide0_enable:1; - int ide1_enable:1; + u8 ide0_enable; + u8 ide1_enable; /* 1 = 80-pin cable, 0 = 40-pin cable */ - int ide0_80pin_cable:1; - int ide1_80pin_cable:1; + u8 ide0_80pin_cable; + u8 ide1_80pin_cable; }; #endif /* SOUTHBRIDGE_VIA_VT8237R_CHIP_H */ -- cgit v1.2.3