From 9361daf7fdaa6a4fa81c06e4cdfb7b42b2915051 Mon Sep 17 00:00:00 2001 From: Andrew Wu Date: Fri, 2 Aug 2013 14:45:03 +0800 Subject: Fix some wait_for_valid functions return value from 1 to -1. codec_init expects wait_for_valid returns -1 for timeout, not 1. Change-Id: I0f2a3ebb1934d0adaf13765434526bbc9efca9a3 Signed-off-by: Andrew Wu Reviewed-on: http://review.coreboot.org/3843 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth Reviewed-by: Paul Menzel Reviewed-by: Stefan Reinauer --- src/southbridge/amd/sb600/hda.c | 2 +- src/southbridge/amd/sb700/hda.c | 2 +- src/southbridge/amd/sb800/hda.c | 2 +- src/southbridge/intel/sch/audio.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) (limited to 'src/southbridge') diff --git a/src/southbridge/amd/sb600/hda.c b/src/southbridge/amd/sb600/hda.c index 711d84b39b..c65f324832 100644 --- a/src/southbridge/amd/sb600/hda.c +++ b/src/southbridge/amd/sb600/hda.c @@ -208,7 +208,7 @@ static int wait_for_valid(u32 base) udelay(1); } - return 1; + return -1; } static void codec_init(u32 base, int addr) diff --git a/src/southbridge/amd/sb700/hda.c b/src/southbridge/amd/sb700/hda.c index 48e472d78a..61cc5859d8 100644 --- a/src/southbridge/amd/sb700/hda.c +++ b/src/southbridge/amd/sb700/hda.c @@ -130,7 +130,7 @@ static int wait_for_valid(u32 base) udelay(1); } - return 1; + return -1; } static void codec_init(u32 base, int addr) diff --git a/src/southbridge/amd/sb800/hda.c b/src/southbridge/amd/sb800/hda.c index c43e9490f0..ad8f80f0d8 100644 --- a/src/southbridge/amd/sb800/hda.c +++ b/src/southbridge/amd/sb800/hda.c @@ -132,7 +132,7 @@ static int wait_for_valid(u32 base) udelay(1); } - return 1; + return -1; } static void codec_init(u32 base, int addr) diff --git a/src/southbridge/intel/sch/audio.c b/src/southbridge/intel/sch/audio.c index 4cb7af2c52..9c7793780a 100644 --- a/src/southbridge/intel/sch/audio.c +++ b/src/southbridge/intel/sch/audio.c @@ -187,7 +187,7 @@ static int wait_for_valid(u32 base) udelay(1); } - return 1; + return -1; } static void codec_init(struct device *dev, u32 base, int addr) -- cgit v1.2.3