From 2b28a160618018b4d7b7930362e1088c2313901b Mon Sep 17 00:00:00 2001 From: Arthur Heymans Date: Tue, 12 Nov 2019 17:21:08 +0100 Subject: sb/intel/bd82x6x: Make the pch_enable_lpc hook optional This also changes the name to mainboard_pch_lpc_setup to better reflect that it is an optional mainboard hook. This adds an empty weakly linked default. The rationale behind this change is that without an implementation of the hook some features might not work but that the result is likely still able to boot, so it can be made optional. Change-Id: Ie8e6056b4c4aed3739d2d12b4224de36fe217189 Signed-off-by: Arthur Heymans Reviewed-on: https://review.coreboot.org/c/coreboot/+/36782 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber --- src/southbridge/intel/bd82x6x/early_pch.c | 6 +++++- src/southbridge/intel/bd82x6x/pch.h | 3 +++ 2 files changed, 8 insertions(+), 1 deletion(-) (limited to 'src/southbridge/intel') diff --git a/src/southbridge/intel/bd82x6x/early_pch.c b/src/southbridge/intel/bd82x6x/early_pch.c index d8fd7ad6a5..8ffb22e140 100644 --- a/src/southbridge/intel/bd82x6x/early_pch.c +++ b/src/southbridge/intel/bd82x6x/early_pch.c @@ -286,12 +286,16 @@ static void pch_enable_lpc_decode(void) pci_write_config32(PCH_LPC_DEV, LPC_GEN4_DEC, config->gen4_dec); } +__weak void mainboard_pch_lpc_setup(void) +{ +} + void early_pch_init(void) { pch_enable_lpc_decode(); - pch_enable_lpc(); + mainboard_pch_lpc_setup(); pch_enable_bars(); diff --git a/src/southbridge/intel/bd82x6x/pch.h b/src/southbridge/intel/bd82x6x/pch.h index d4cd86eaa5..127fb61cce 100644 --- a/src/southbridge/intel/bd82x6x/pch.h +++ b/src/southbridge/intel/bd82x6x/pch.h @@ -75,6 +75,9 @@ void southbridge_rcba_config(void); /* Optional mainboard hook to do additional configuration on the RCBA config space. It is called after the raminit. */ void mainboard_late_rcba_config(void); +/* Optional mainboard hook to do additional LPC configuration + or to override what is set up by default. */ +void mainboard_pch_lpc_setup(void); void early_pch_init_native(void); void early_pch_init(void); void early_pch_init_native_dmi_pre(void); -- cgit v1.2.3