From f6f1215cdbbae04de8f84654d064b376395cf203 Mon Sep 17 00:00:00 2001 From: Kyösti Mälkki Date: Tue, 29 Dec 2020 09:04:30 +0200 Subject: sb,soc/intel: Drop OSYS from GNVS MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The value should be set by OSPM using some combination of _OSI() queris in the \_SB._INI() method. To maintain previous behaviour with this commit, boards where GNVS osys initialisation was removed now do the same in ASL. Change-Id: Id4957b12a72fbf7fa988e7ff039e47abcc072e1c Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/c/coreboot/+/49353 Reviewed-by: Arthur Heymans Reviewed-by: Angel Pons Tested-by: build bot (Jenkins) --- src/southbridge/intel/lynxpoint/acpi/globalnvs.asl | 2 +- src/southbridge/intel/lynxpoint/include/soc/nvs.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'src/southbridge/intel/lynxpoint') diff --git a/src/southbridge/intel/lynxpoint/acpi/globalnvs.asl b/src/southbridge/intel/lynxpoint/acpi/globalnvs.asl index d0c08a14be..d422adbb88 100644 --- a/src/southbridge/intel/lynxpoint/acpi/globalnvs.asl +++ b/src/southbridge/intel/lynxpoint/acpi/globalnvs.asl @@ -7,7 +7,7 @@ Name (\PICM, 0) // IOAPIC/8259 Field (GNVS, ByteAcc, NoLock, Preserve) { /* Miscellaneous */ - OSYS, 16, // 0x00 - Operating System + , 16, // 0x00 - Operating System SMIF, 8, // 0x02 - SMI function PRM0, 8, // 0x03 - SMI function parameter PRM1, 8, // 0x04 - SMI function parameter diff --git a/src/southbridge/intel/lynxpoint/include/soc/nvs.h b/src/southbridge/intel/lynxpoint/include/soc/nvs.h index 5bda60d95a..39b51cc557 100644 --- a/src/southbridge/intel/lynxpoint/include/soc/nvs.h +++ b/src/southbridge/intel/lynxpoint/include/soc/nvs.h @@ -7,7 +7,7 @@ struct __packed global_nvs { /* Miscellaneous */ - u16 osys; /* 0x00 - Operating System */ + u16 unused_was_osys; /* 0x00 - Operating System */ u8 smif; /* 0x02 - SMI function call ("TRAP") */ u8 prm0; /* 0x03 - SMI function call parameter */ u8 prm1; /* 0x04 - SMI function call parameter */ -- cgit v1.2.3