From ad882c3b171ccd71d84ddc971ab0c4ae563190de Mon Sep 17 00:00:00 2001 From: Kyösti Mälkki Date: Tue, 2 Jun 2020 05:05:30 +0300 Subject: sb/intel: Remove spurious HAVE_SMI_HANDLER test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit There are no side-effects in calling acpi_is_wakeup_s3() and apm_control() is a no-op with HAVE_SMI_HANDLER=n. Change-Id: Ia9195781955cc5fa96d0690aa7735fc590e527e4 Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/c/coreboot/+/41986 Reviewed-by: Angel Pons Reviewed-by: Paul Menzel Reviewed-by: Patrick Rudolph Tested-by: build bot (Jenkins) --- src/southbridge/intel/lynxpoint/lpc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'src/southbridge/intel/lynxpoint') diff --git a/src/southbridge/intel/lynxpoint/lpc.c b/src/southbridge/intel/lynxpoint/lpc.c index bf03125a8a..6cdbc78212 100644 --- a/src/southbridge/intel/lynxpoint/lpc.c +++ b/src/southbridge/intel/lynxpoint/lpc.c @@ -473,9 +473,8 @@ static void enable_lp_clock_gating(struct device *dev) static void pch_set_acpi_mode(void) { - if (CONFIG(HAVE_SMI_HANDLER) && !acpi_is_wakeup_s3()) { + if (!acpi_is_wakeup_s3()) apm_control(APM_CNT_ACPI_DISABLE); - } } static void pch_disable_smm_only_flashing(struct device *dev) -- cgit v1.2.3