From 6c03160d48f9b2d1dfaf5a193893b011e71ac30e Mon Sep 17 00:00:00 2001 From: Duncan Laurie Date: Tue, 11 Feb 2014 10:34:06 -0800 Subject: lynxpoint: Do not put SerialIO devices into D3Hot in ACPI mode Remove the bit of code that was putting the SerialIO devices into D3Hot state when they are switched from PCI to ACPI mode. Instead, add the appropriate ACPI Methods to allow the kernel to control the power state of the device. The problem seems to be that if the device is put in D3Hot state before it is switched from PCI to ACPI mode then it does not properly export its PCI configuration space and cannot be woken back up. Adding the ACPI Methods for _PS0/_PS3 allows the kernel to transition the device into D0 state only when it is necessary to communicate with the device, then put it back into D3Hot state. Change-Id: I2384ba10bf47750d1c1a35216169ddeee26881df Signed-off-by: Duncan Laurie Reviewed-on: http://review.coreboot.org/5193 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Stefan Reinauer --- src/southbridge/intel/lynxpoint/serialio.c | 10 ---------- 1 file changed, 10 deletions(-) (limited to 'src/southbridge/intel/lynxpoint/serialio.c') diff --git a/src/southbridge/intel/lynxpoint/serialio.c b/src/southbridge/intel/lynxpoint/serialio.c index 8257cc2f6f..75edf5c9db 100644 --- a/src/southbridge/intel/lynxpoint/serialio.c +++ b/src/southbridge/intel/lynxpoint/serialio.c @@ -29,14 +29,6 @@ #include "pch.h" #include "nvs.h" -/* Set D3Hot Power State in ACPI mode */ -static void serialio_enable_d3hot(struct device *dev) -{ - u32 reg32 = pci_read_config32(dev, PCH_PCS); - reg32 |= PCH_PCS_PS_D3HOT; - pci_write_config32(dev, PCH_PCS, reg32); -} - /* Enable clock in PCI mode */ static void serialio_enable_clock(struct resource *bar0) { @@ -178,8 +170,6 @@ static void serialio_init(struct device *dev) if (!config->sio_acpi_mode) serialio_enable_clock(bar0); - else if (dev->path.pci.devfn != PCI_DEVFN(21, 0)) - serialio_enable_d3hot(dev); /* all but SDMA */ switch (dev->path.pci.devfn) { case PCI_DEVFN(21, 0): /* SDMA */ -- cgit v1.2.3