From e61dd0f7a2be83ce5ba87d74f7384111576ffd49 Mon Sep 17 00:00:00 2001 From: Edward O'Callaghan Date: Tue, 6 May 2014 23:53:09 +1000 Subject: southbridge/amd/sb?00/lpc.c: Move i8254/i8259 down in southbridge MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We should configure i8254/i8259 down in to the southbridge rather than romstage of every AGESA/CIMx board much like Intel boards do. Change-Id: Id7c4f0baa0819d52aef9b0ee03c20d0fa16b9352 Signed-off-by: Edward O'Callaghan Reviewed-on: http://review.coreboot.org/5669 Tested-by: build bot (Jenkins) Reviewed-by: Kyösti Mälkki --- src/southbridge/amd/cimx/sb700/late.c | 5 +++++ src/southbridge/amd/cimx/sb800/late.c | 5 +++++ src/southbridge/amd/cimx/sb900/late.c | 5 +++++ 3 files changed, 15 insertions(+) (limited to 'src/southbridge/amd/cimx') diff --git a/src/southbridge/amd/cimx/sb700/late.c b/src/southbridge/amd/cimx/sb700/late.c index 96050830fb..42330ca1e9 100644 --- a/src/southbridge/amd/cimx/sb700/late.c +++ b/src/southbridge/amd/cimx/sb700/late.c @@ -24,6 +24,8 @@ #include #include /* smbus_bus_operations */ #include +#include +#include #include /* printk */ #include #include "lpc.h" /* lpc_read_resources */ @@ -87,6 +89,9 @@ static void lpc_init(device_t dev) */ rtc_init(0); + setup_i8259(); /* Initialize i8259 pic */ + setup_i8254(); /* Initialize i8254 timers */ + printk(BIOS_DEBUG, "SB700 - Late.c - lpc_init - End.\n"); } diff --git a/src/southbridge/amd/cimx/sb800/late.c b/src/southbridge/amd/cimx/sb800/late.c index 219118aa25..40b422bc83 100644 --- a/src/southbridge/amd/cimx/sb800/late.c +++ b/src/southbridge/amd/cimx/sb800/late.c @@ -24,6 +24,8 @@ #include #include /* smbus_bus_operations */ #include +#include +#include #include /* printk */ #include #include @@ -136,6 +138,9 @@ static void lpc_init(device_t dev) */ rtc_init(0); + setup_i8259(); /* Initialize i8259 pic */ + setup_i8254(); /* Initialize i8254 timers */ + printk(BIOS_DEBUG, "SB800 - Late.c - lpc_init - End.\n"); } diff --git a/src/southbridge/amd/cimx/sb900/late.c b/src/southbridge/amd/cimx/sb900/late.c index 3cd603ca7a..7303bdceba 100644 --- a/src/southbridge/amd/cimx/sb900/late.c +++ b/src/southbridge/amd/cimx/sb900/late.c @@ -23,6 +23,8 @@ #include #include /* smbus_bus_operations */ #include +#include +#include #include /* printk */ #include #include "lpc.h" /* lpc_read_resources */ @@ -109,6 +111,9 @@ static void lpc_init(device_t dev) */ rtc_init(0); + setup_i8259(); /* Initialize i8259 pic */ + setup_i8254(); /* Initialize i8254 timers */ + printk(BIOS_DEBUG, "SB900 - Late.c - lpc_init - End.\n"); } -- cgit v1.2.3