From fac11d000ab73c306bba6798aff55bc73afa11dd Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Thu, 17 Feb 2022 20:40:55 +0530 Subject: soc/intel/denverton_ns: Select PMC PCI discoverable config MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This patch selects SOC_INTEL_COMMON_BLOCK_PMC_DISCOVERABLE config to reflect the SoC actual behaviour where PMC PCI device is still visible over bus even after FSP-S exit. Additionally, add DNV PMC PCI ID into PMC IA-common code. Signed-off-by: Subrata Banik Change-Id: Iaaea20e54c909800e4d75b58c29507fc1944cfba Reviewed-on: https://review.coreboot.org/c/coreboot/+/62135 Tested-by: build bot (Jenkins) Reviewed-by: Michael Niewöhner Reviewed-by: Mariusz Szafrański --- src/soc/intel/common/block/pmc/pmc.c | 1 + src/soc/intel/denverton_ns/Kconfig | 1 + src/soc/intel/denverton_ns/include/soc/iomap.h | 2 + src/soc/intel/denverton_ns/pmc.c | 82 ++++++-------------------- 4 files changed, 23 insertions(+), 63 deletions(-) (limited to 'src/soc') diff --git a/src/soc/intel/common/block/pmc/pmc.c b/src/soc/intel/common/block/pmc/pmc.c index 333bace04f..b64841d616 100644 --- a/src/soc/intel/common/block/pmc/pmc.c +++ b/src/soc/intel/common/block/pmc/pmc.c @@ -111,6 +111,7 @@ static struct device_operations device_ops = { }; static const unsigned short pci_device_ids[] = { + PCI_DEVICE_ID_INTEL_DNV_PMC, PCI_DEVICE_ID_INTEL_SPT_LP_PMC, PCI_DEVICE_ID_INTEL_SPT_H_PMC, PCI_DEVICE_ID_INTEL_LWB_PMC, diff --git a/src/soc/intel/denverton_ns/Kconfig b/src/soc/intel/denverton_ns/Kconfig index 4c0c998792..194067a555 100644 --- a/src/soc/intel/denverton_ns/Kconfig +++ b/src/soc/intel/denverton_ns/Kconfig @@ -37,6 +37,7 @@ config CPU_SPECIFIC_OPTIONS select SOC_INTEL_COMMON_BLOCK_FAST_SPI select SOC_INTEL_COMMON_BLOCK_GPIO select SOC_INTEL_COMMON_BLOCK_PCR + select SOC_INTEL_COMMON_BLOCK_PMC_DISCOVERABLE select SOC_INTEL_COMMON_BLOCK_SMBUS select SUPPORT_CPU_UCODE_IN_CBFS select SOUTHBRIDGE_INTEL_COMMON_SMBUS diff --git a/src/soc/intel/denverton_ns/include/soc/iomap.h b/src/soc/intel/denverton_ns/include/soc/iomap.h index c252ca11b6..ca14719079 100644 --- a/src/soc/intel/denverton_ns/include/soc/iomap.h +++ b/src/soc/intel/denverton_ns/include/soc/iomap.h @@ -12,6 +12,7 @@ /* Southbridge internal device IO BARs (Set to match FSP settings) */ #define DEFAULT_PMBASE 0x1800 +#define DEFAULT_PMBASE_SIZE 0x100 #define ACPI_BASE_ADDRESS DEFAULT_PMBASE #define DEFAULT_TCO_BASE 0x400 @@ -20,6 +21,7 @@ /* Southbridge internal device MEM BARs (Set to match FSP settings) */ #define DEFAULT_PCR_BASE 0xfd000000 #define DEFAULT_PWRM_BASE 0xfe000000 +#define DEFAULT_PWRM_SIZE 0x10000 #define DEFAULT_HPET_ADDR CONFIG_HPET_ADDRESS #define DEFAULT_SPI_BASE 0xfed01000 diff --git a/src/soc/intel/denverton_ns/pmc.c b/src/soc/intel/denverton_ns/pmc.c index a01005e8aa..b1a37a9ce3 100644 --- a/src/soc/intel/denverton_ns/pmc.c +++ b/src/soc/intel/denverton_ns/pmc.c @@ -3,25 +3,33 @@ #include #include #include +#include #include #include #include #include - +#include #include +#include #include #include #include -#include - -/* While we read BAR dynamically in case it changed, let's - * initialize it with a same value - */ -static u16 acpi_base = ACPI_BASE_ADDRESS; -static u32 pwrm_base = DEFAULT_PWRM_BASE; static void pch_power_options(struct device *dev) { /* TODO */ } +/* Fill up PMC resource structure */ +int pmc_soc_get_resources(struct pmc_resource_config *cfg) +{ + cfg->pwrmbase_offset = PMC_PWRM_BASE; + cfg->pwrmbase_addr = DEFAULT_PWRM_BASE; + cfg->pwrmbase_size = DEFAULT_PWRM_SIZE; + cfg->abase_offset = PMC_ACPI_BASE; + cfg->abase_addr = DEFAULT_PMBASE; + cfg->abase_size = DEFAULT_PMBASE_SIZE; + + return 0; +} + static void pch_set_acpi_mode(void) { if (!acpi_is_wakeup_s3()) { @@ -29,13 +37,11 @@ static void pch_set_acpi_mode(void) } } -static void pmc_init(struct device *dev) +void pmc_soc_init(struct device *dev) { - printk(BIOS_DEBUG, "pch: %s\n", __func__); + uint32_t pwrm_base = pci_read_config32(dev, PMC_PWRM_BASE) & MASK_PMC_PWRM_BASE; - /* Get the base address */ - acpi_base = pci_read_config16(dev, PMC_ACPI_BASE) & MASK_PMC_ACPI_BASE; - pwrm_base = pci_read_config32(dev, PMC_PWRM_BASE) & MASK_PMC_PWRM_BASE; + printk(BIOS_DEBUG, "pch: %s\n", __func__); /* Set the value for PCI command register. */ pci_write_config16(dev, PCI_COMMAND, PCI_COMMAND_MASTER | @@ -58,53 +64,3 @@ static void pmc_init(struct device *dev) setbits8((volatile void *)(uintptr_t)(pwrm_base + PCH_PWRM_ACPI_TMR_CTL), ACPI_TIM_DIS); } - -static void pci_pmc_read_resources(struct device *dev) -{ - struct resource *res; - - /* Get the normal PCI resources of this device. */ - pci_dev_read_resources(dev); - - /* Add MMIO resource - * Use 0xaa as an unused index for PWRM BAR. - */ - u32 reg32 = pci_read_config32(dev, PMC_PWRM_BASE) & MASK_PMC_PWRM_BASE; - if ((reg32 != 0x0) && (reg32 != 0xffffffff)) { - res = new_resource(dev, 0xaa); - res->base = reg32; - res->size = 64 * 1024; /* 64K bytes memory config space */ - res->flags = - IORESOURCE_MEM | IORESOURCE_ASSIGNED | IORESOURCE_FIXED; - printk(BIOS_DEBUG, - "Adding PMC PWRM config space BAR 0x%08lx-0x%08lx.\n", - (unsigned long)(res->base), - (unsigned long)(res->base + res->size)); - } - - /* Add MMIO resource - * Use 0xab as an unused index for ACPI BAR. - */ - u16 reg16 = pci_read_config16(dev, PMC_ACPI_BASE) & MASK_PMC_ACPI_BASE; - if ((reg16 != 0x0) && (reg16 != 0xffff)) { - res = new_resource(dev, 0xab); - res->base = reg16; - res->size = 0x100; /* 256 bytes I/O config space */ - res->flags = IORESOURCE_IO | IORESOURCE_SUBTRACTIVE | - IORESOURCE_ASSIGNED | IORESOURCE_FIXED; - } -} - -static struct device_operations pmc_ops = { - .read_resources = pci_pmc_read_resources, - .set_resources = pci_dev_set_resources, - .enable_resources = pci_dev_enable_resources, - .init = pmc_init, - .ops_pci = &soc_pci_ops, -}; - -static const struct pci_driver pch_pmc __pci_driver = { - .ops = &pmc_ops, - .vendor = PCI_VENDOR_ID_INTEL, - .device = PCI_DEVICE_ID_INTEL_DNV_PMC, -}; -- cgit v1.2.3