From eafcc8e5b1122f30e265f77271a18a9124e4dc9e Mon Sep 17 00:00:00 2001 From: Arthur Heymans Date: Mon, 23 May 2022 16:09:51 +0200 Subject: arch/x86/acpi_bert_storage.c: Use a common implementation All targets now use cbmem for the BERT region, so the implementation can be common. This also drops the obsolete comment about the need to have bert in a reserved region (cbmem gets fixed to be in a reserved region). Change-Id: I6f33d9e05a02492a1c91fb7af94aadaa9acd2931 Signed-off-by: Arthur Heymans Reviewed-on: https://review.coreboot.org/c/coreboot/+/64602 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Raul Rangel Reviewed-by: Felix Held --- src/soc/amd/common/block/cpu/noncar/memmap.c | 8 -------- src/soc/amd/stoneyridge/memmap.c | 13 ------------- src/soc/intel/common/block/systemagent/Kconfig | 8 ++++++++ src/soc/intel/common/block/systemagent/memmap.c | 11 ----------- 4 files changed, 8 insertions(+), 32 deletions(-) (limited to 'src/soc') diff --git a/src/soc/amd/common/block/cpu/noncar/memmap.c b/src/soc/amd/common/block/cpu/noncar/memmap.c index 6e35003f0f..dd057c05fa 100644 --- a/src/soc/amd/common/block/cpu/noncar/memmap.c +++ b/src/soc/amd/common/block/cpu/noncar/memmap.c @@ -2,7 +2,6 @@ #include #include -#include #include #include #include @@ -59,10 +58,3 @@ void smm_region(uintptr_t *start, size_t *size) once = 1; } } - -void bert_reserved_region(void **start, size_t *size) -{ - *start = cbmem_add(CBMEM_ID_ACPI_BERT, CONFIG_ACPI_BERT_SIZE); - *size = CONFIG_ACPI_BERT_SIZE; - printk(BIOS_INFO, "Reserved BERT region base: %p, size: 0x%zx\n", *start, *size); -} diff --git a/src/soc/amd/stoneyridge/memmap.c b/src/soc/amd/stoneyridge/memmap.c index e411aa2ef3..f7c6b0075c 100644 --- a/src/soc/amd/stoneyridge/memmap.c +++ b/src/soc/amd/stoneyridge/memmap.c @@ -8,23 +8,10 @@ #include #include #include -#include #include #include #include -void bert_reserved_region(void **start, size_t *size) -{ - if (!CONFIG(ACPI_BERT)) { - *start = NULL; - *size = 0; - } else { - *start = cbmem_add(CBMEM_ID_ACPI_BERT, CONFIG_ACPI_BERT_SIZE); - *size = CONFIG_ACPI_BERT_SIZE; - } - printk(BIOS_INFO, "Reserved BERT region base: %p, size: 0x%zx\n", *start, *size); -} - void *cbmem_top_chipset(void) { msr_t tom = rdmsr(TOP_MEM); diff --git a/src/soc/intel/common/block/systemagent/Kconfig b/src/soc/intel/common/block/systemagent/Kconfig index e9519bc624..e7f6ba49d8 100644 --- a/src/soc/intel/common/block/systemagent/Kconfig +++ b/src/soc/intel/common/block/systemagent/Kconfig @@ -23,4 +23,12 @@ config SA_ENABLE_DPR help This option allows you to add the DMA Protected Range (DPR). +config ACPI_BERT_SIZE + hex + default 0x10000 if ACPI_BERT + default 0x0 + help + Specify the amount of DRAM reserved for gathering the data used to + generate the ACPI table. + endif diff --git a/src/soc/intel/common/block/systemagent/memmap.c b/src/soc/intel/common/block/systemagent/memmap.c index a67d050fcc..86ca4e1b84 100644 --- a/src/soc/intel/common/block/systemagent/memmap.c +++ b/src/soc/intel/common/block/systemagent/memmap.c @@ -7,7 +7,6 @@ #include #include #include -#include #include /* @@ -50,22 +49,12 @@ * +---------------------------+ 0 */ -#define BERT_REGION_MAX_SIZE 0x10000 - void smm_region(uintptr_t *start, size_t *size) { *start = sa_get_tseg_base(); *size = sa_get_tseg_size(); } -void bert_reserved_region(void **start, size_t *size) -{ - *start = cbmem_add(CBMEM_ID_ACPI_BERT, BERT_REGION_MAX_SIZE); - *size = BERT_REGION_MAX_SIZE; - - printk(BIOS_DEBUG, "Reserving BERT start %lx, size %zx\n", (uintptr_t)*start, *size); -} - void fill_postcar_frame(struct postcar_frame *pcf) { /* FSP does not seem to bother w.r.t. alignment when asked to place cbmem_top() */ -- cgit v1.2.3