From e43adb67bc699faa3e2e895da3260e526eb21c7b Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Tue, 31 May 2022 23:28:57 +0530 Subject: soc/intel/cmn/block/cpu: Set BIOS_DONE on all CPUs As per Intel Processor EDS, BIOS_DONE bit needs to be set on all CPUs via MSR. Also, implement a function to perform any SoC recommended CPU programming prior to post CPUs init. At present calling `cpu_soc_bios_done()` for all CPUs from `before_post_cpus_init()`. Note: It is expected that `before_post_cpus_init()` will be extended with other CPU programming recommendations in follow up patches, for example: reload microcode patch etc. BUG=b:233199592 TEST=Build and boot google/taeko to ChromeOS. Signed-off-by: Subrata Banik Change-Id: I8066cd724c9f15d259aeb23f3aa71a2d224d5340 Reviewed-on: https://review.coreboot.org/c/coreboot/+/64834 Tested-by: build bot (Jenkins) Reviewed-by: Lean Sheng Tan --- src/soc/intel/common/block/cpu/mp_init.c | 11 +++++++++++ src/soc/intel/common/block/include/intelblocks/mp_init.h | 7 +++++++ 2 files changed, 18 insertions(+) (limited to 'src/soc') diff --git a/src/soc/intel/common/block/cpu/mp_init.c b/src/soc/intel/common/block/cpu/mp_init.c index 9b4278fa1b..cec767a9a0 100644 --- a/src/soc/intel/common/block/cpu/mp_init.c +++ b/src/soc/intel/common/block/cpu/mp_init.c @@ -167,6 +167,17 @@ static void wrapper_x86_setup_mtrrs(void *unused) x86_setup_mtrrs_with_detect(); } +static void wrapper_set_bios_done(void *unused) +{ + cpu_soc_bios_done(); +} + +void before_post_cpus_init(void) +{ + if (mp_run_on_all_cpus(&wrapper_set_bios_done, NULL) != CB_SUCCESS) + printk(BIOS_ERR, "Set BIOS Done failure\n"); +} + /* Ensure to re-program all MTRRs based on DRAM resource settings */ static void post_cpus_init(void *unused) { diff --git a/src/soc/intel/common/block/include/intelblocks/mp_init.h b/src/soc/intel/common/block/include/intelblocks/mp_init.h index 8a413eae8c..9029c91c45 100644 --- a/src/soc/intel/common/block/include/intelblocks/mp_init.h +++ b/src/soc/intel/common/block/include/intelblocks/mp_init.h @@ -33,6 +33,13 @@ void get_microcode_info(const void **microcode, int *parallel); */ void init_cpus(void); +/* + * This function will perform any recommended CPU (BSP and AP) initialization + * after coreboot has done the multiprocessor initialization (before FSP-S) + * and prior to coreboot perform post_cpus_init (after DRAM resources are set). + */ +void before_post_cpus_init(void); + /* * SoC Overrides * -- cgit v1.2.3