From d591a5a328b7185f7e6e4ff755f74594e7232dfc Mon Sep 17 00:00:00 2001
From: Kyösti Mälkki <kyosti.malkki@gmail.com>
Date: Mon, 25 Jan 2021 17:05:35 +0200
Subject: ACPI: Move common _PIC method
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Change-Id: I659835354570fb1d4860fcbddf2a51831170a374
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/50470
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
---
 src/soc/amd/picasso/acpi/pci_int.asl              |  6 ------
 src/soc/amd/stoneyridge/acpi/pci_int.asl          |  5 -----
 src/soc/intel/common/block/acpi/acpi/platform.asl | 14 --------------
 3 files changed, 25 deletions(-)

(limited to 'src/soc')

diff --git a/src/soc/amd/picasso/acpi/pci_int.asl b/src/soc/amd/picasso/acpi/pci_int.asl
index f95dcb0659..06ba0ccbf7 100644
--- a/src/soc/amd/picasso/acpi/pci_int.asl
+++ b/src/soc/amd/picasso/acpi/pci_int.asl
@@ -1,11 +1,5 @@
 /* SPDX-License-Identifier: GPL-2.0-only */
 
-	Method(\_PIC, 0x01, NotSerialized)
-	{
-		printf("PIC MODE: %o", Arg0)
-		PICM = Arg0
-	}
-
 	/* PIC Possible Resource Values */
 	Name(IRQP, ResourceTemplate() {
 		Interrupt(ResourceConsumer, Level, ActiveLow, Exclusive, , , PIC){
diff --git a/src/soc/amd/stoneyridge/acpi/pci_int.asl b/src/soc/amd/stoneyridge/acpi/pci_int.asl
index d558e651f5..0f1feef05a 100644
--- a/src/soc/amd/stoneyridge/acpi/pci_int.asl
+++ b/src/soc/amd/stoneyridge/acpi/pci_int.asl
@@ -103,11 +103,6 @@
 		P3PR, 1,
 	}
 
-	Method(\_PIC, 0x01, NotSerialized)
-	{
-		PICM = Arg0
-	}
-
 	Name(IRQB, ResourceTemplate(){
 		IRQ(Level,ActiveLow,Shared){15}
 	})
diff --git a/src/soc/intel/common/block/acpi/acpi/platform.asl b/src/soc/intel/common/block/acpi/acpi/platform.asl
index 4b01aeb464..8a26756911 100644
--- a/src/soc/intel/common/block/acpi/acpi/platform.asl
+++ b/src/soc/intel/common/block/acpi/acpi/platform.asl
@@ -4,17 +4,3 @@
 #include <soc/intel/common/acpi/acpi_wake_source.asl>
 /* Generic indicator for sleep state */
 #include <soc/intel/common/acpi/platform.asl>
-
-/*
- * The _PIC method is called by the OS to choose between interrupt
- * routing via the i8259 interrupt controller or the APIC.
- *
- * _PIC is called with a parameter of 0 for i8259 configuration and
- * with a parameter of 1 for Local Apic/IOAPIC configuration.
- */
-
-Method (_PIC, 1)
-{
-	/* Remember the OS' IRQ routing choice. */
-	PICM = Arg0
-}
-- 
cgit v1.2.3