From cc34162734b4d924012102210095bcf8903ea758 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Fri, 3 Mar 2023 18:02:05 +0100 Subject: soc/amd/*/acpi: drop unneeded pstate_cnt FADT assignment The FADT data structure is zero-initialized in acpi_create_fadt which then calls the SoC-specific acpi_fill_fadt function, therefore it's not needed to assign 0 to the pstate_cnt FADT field in acpi_fill_fadt. Signed-off-by: Felix Held Change-Id: If3ddb466de1d437361d811e45e328a1dbff02fcc Reviewed-on: https://review.coreboot.org/c/coreboot/+/73419 Tested-by: build bot (Jenkins) Reviewed-by: Elyes Haouas Reviewed-by: Paul Menzel Reviewed-by: Eric Lai Reviewed-by: Fred Reitberger --- src/soc/amd/cezanne/acpi.c | 2 -- src/soc/amd/glinda/acpi.c | 2 -- src/soc/amd/mendocino/acpi.c | 2 -- src/soc/amd/phoenix/acpi.c | 2 -- 4 files changed, 8 deletions(-) (limited to 'src/soc') diff --git a/src/soc/amd/cezanne/acpi.c b/src/soc/amd/cezanne/acpi.c index 89261cff78..35b3989308 100644 --- a/src/soc/amd/cezanne/acpi.c +++ b/src/soc/amd/cezanne/acpi.c @@ -62,8 +62,6 @@ void acpi_fill_fadt(acpi_fadt_t *fadt) fadt->acpi_disable = APM_CNT_ACPI_DISABLE; } - fadt->pstate_cnt = 0; - fadt->pm1a_evt_blk = ACPI_PM_EVT_BLK; fadt->pm1a_cnt_blk = ACPI_PM1_CNT_BLK; fadt->pm_tmr_blk = ACPI_PM_TMR_BLK; diff --git a/src/soc/amd/glinda/acpi.c b/src/soc/amd/glinda/acpi.c index 322e44e8af..7c66d54808 100644 --- a/src/soc/amd/glinda/acpi.c +++ b/src/soc/amd/glinda/acpi.c @@ -65,8 +65,6 @@ void acpi_fill_fadt(acpi_fadt_t *fadt) fadt->acpi_disable = APM_CNT_ACPI_DISABLE; } - fadt->pstate_cnt = 0; - fadt->pm1a_evt_blk = ACPI_PM_EVT_BLK; fadt->pm1a_cnt_blk = ACPI_PM1_CNT_BLK; fadt->pm_tmr_blk = ACPI_PM_TMR_BLK; diff --git a/src/soc/amd/mendocino/acpi.c b/src/soc/amd/mendocino/acpi.c index f5199174c5..03e2381394 100644 --- a/src/soc/amd/mendocino/acpi.c +++ b/src/soc/amd/mendocino/acpi.c @@ -64,8 +64,6 @@ void acpi_fill_fadt(acpi_fadt_t *fadt) fadt->acpi_disable = APM_CNT_ACPI_DISABLE; } - fadt->pstate_cnt = 0; - fadt->pm1a_evt_blk = ACPI_PM_EVT_BLK; fadt->pm1a_cnt_blk = ACPI_PM1_CNT_BLK; fadt->pm_tmr_blk = ACPI_PM_TMR_BLK; diff --git a/src/soc/amd/phoenix/acpi.c b/src/soc/amd/phoenix/acpi.c index f082518b1e..8f6dfb57b7 100644 --- a/src/soc/amd/phoenix/acpi.c +++ b/src/soc/amd/phoenix/acpi.c @@ -65,8 +65,6 @@ void acpi_fill_fadt(acpi_fadt_t *fadt) fadt->acpi_disable = APM_CNT_ACPI_DISABLE; } - fadt->pstate_cnt = 0; - fadt->pm1a_evt_blk = ACPI_PM_EVT_BLK; fadt->pm1a_cnt_blk = ACPI_PM1_CNT_BLK; fadt->pm_tmr_blk = ACPI_PM_TMR_BLK; -- cgit v1.2.3