From a67c753d554c730c794726b1b65d07c9c383e264 Mon Sep 17 00:00:00 2001
From: Felix Held <felix.held@amd.corp-partner.google.com>
Date: Sun, 12 Apr 2020 02:17:44 +0200
Subject: soc/amd/picasso/soc_util: add TODO to Dali detection

Change-Id: I8ff5a9275d4cdf0049b63cc30b8a1cc376b50f80
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40321
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
---
 src/soc/amd/picasso/soc_util.c | 4 ++++
 1 file changed, 4 insertions(+)

(limited to 'src/soc')

diff --git a/src/soc/amd/picasso/soc_util.c b/src/soc/amd/picasso/soc_util.c
index 893ff2570f..7cd050cae6 100644
--- a/src/soc/amd/picasso/soc_util.c
+++ b/src/soc/amd/picasso/soc_util.c
@@ -10,6 +10,10 @@ int soc_is_pollock(void)
 	return soc_is_zen_plus() && CONFIG(AMD_FT5);
 }
 
+/*
+ * TODO: This detection works for the Dali SKUs used in Chrome-devices, but fails for other
+ * Dali SKUs, since other Dali SKUs have a Zen+ CPUID and not a Raven2 one.
+ */
 int soc_is_dali(void)
 {
 	return soc_is_raven2() && CONFIG(AMD_FP5);
-- 
cgit v1.2.3