From a0975050fa01d9dd5d20531de9727a694eb60e4c Mon Sep 17 00:00:00 2001 From: Sean Rhodes Date: Wed, 30 Aug 2023 12:47:59 +0100 Subject: soc/intel/meteorlake: Correctly set Usb4CmMode MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The ACPI is adjusted based on SOFTWARE_CONNECTION_MANAGER, so set the UPD to match this to avoid the connection type being mismatched. If it's mismatched, the TBT port will timeout. TEST=Boot starbook/rpl and check TBT 4 dock is correctly identified. Signed-off-by: Sean Rhodes Change-Id: I3ab68c01f682723dab39870f0676e59ae3d89add Reviewed-on: https://review.coreboot.org/c/coreboot/+/77567 Reviewed-by: Tim Crawford Reviewed-by: Ronak Kanabar Tested-by: build bot (Jenkins) Reviewed-by: Michał Kopeć Reviewed-by: Angel Pons --- src/soc/intel/meteorlake/fsp_params.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'src/soc') diff --git a/src/soc/intel/meteorlake/fsp_params.c b/src/soc/intel/meteorlake/fsp_params.c index bf1d9d54f1..702820a788 100644 --- a/src/soc/intel/meteorlake/fsp_params.c +++ b/src/soc/intel/meteorlake/fsp_params.c @@ -442,6 +442,8 @@ static void fill_fsps_tcss_params(FSP_S_CONFIG *s_cfg, if (is_dev_enabled(tcss_port_arr[i])) s_cfg->UsbTcPortEn |= BIT(i); } + + s_cfg->Usb4CmMode = CONFIG(SOFTWARE_CONNECTION_MANAGER); } static void fill_fsps_chipset_lockdown_params(FSP_S_CONFIG *s_cfg, -- cgit v1.2.3