From 83729bd430425ef9b161ebb9260ad047d3920d7c Mon Sep 17 00:00:00 2001 From: Marc Jones Date: Thu, 5 Nov 2020 17:30:26 -0700 Subject: soc/intel/xeon_sp/skx: Fix MADT CPU indexes The CPU index wasn't getting updated. Confirm MADT sets IOAPIC and CPU ID numbers. Change-Id: I72430cc48f4609ac408e723172ba1ed263cca8e3 Signed-off-by: Marc Jones Reviewed-on: https://review.coreboot.org/c/coreboot/+/47277 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer Reviewed-by: Arthur Heymans --- src/soc/intel/xeon_sp/skx/soc_acpi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/soc') diff --git a/src/soc/intel/xeon_sp/skx/soc_acpi.c b/src/soc/intel/xeon_sp/skx/soc_acpi.c index b3926193da..95563f5837 100644 --- a/src/soc/intel/xeon_sp/skx/soc_acpi.c +++ b/src/soc/intel/xeon_sp/skx/soc_acpi.c @@ -182,7 +182,7 @@ void soc_power_states_generation(int core, int cores_per_package) unsigned long xeonsp_acpi_create_madt_lapics(unsigned long current) { struct device *cpu; - int num_cpus = 0; + uint8_t num_cpus = 0; for (cpu = all_devices; cpu; cpu = cpu->next) { if ((cpu->path.type != DEVICE_PATH_APIC) || @@ -193,6 +193,7 @@ unsigned long xeonsp_acpi_create_madt_lapics(unsigned long current) continue; current += acpi_create_madt_lapic((acpi_madt_lapic_t *)current, num_cpus, cpu->path.apic.apic_id); + num_cpus++; } return current; -- cgit v1.2.3