From 80f95b5214fd716bb146f795a0dd3921c088280e Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Mon, 13 Sep 2021 17:53:05 -0500 Subject: soc/broadwell/acpi.c: Fix unresolvable symbol '\DNVS' Fixes: 27c51a0 ("Revert "soc/intel/broadwell/pch: Replace ACPI device NVS"") which reverted the removal of device NVS, but was not boot tested on any Broadwell Chromebooks. It was recently discovered that the DNVS object was not being loaded, due to a weak function setting the size as zero not being defined for the platform/soc. Add the missing overloaded function and required headers. Test: build/boot google/auron variants LULU ans SAMUS, verify touchpad functional and no ACPI errors in kernel boot log. Change-Id: Icd317d117dbb068bb6da80fe56c06c0267c7b2ae Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/57630 Tested-by: build bot (Jenkins) Reviewed-by: Furquan Shaikh Reviewed-by: Angel Pons Reviewed-by: Paul Menzel --- src/soc/intel/broadwell/acpi.c | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'src/soc') diff --git a/src/soc/intel/broadwell/acpi.c b/src/soc/intel/broadwell/acpi.c index 67b193e1f7..512f9f3d46 100644 --- a/src/soc/intel/broadwell/acpi.c +++ b/src/soc/intel/broadwell/acpi.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include +#include #include #include #include @@ -12,6 +13,7 @@ #include #include #include +#include #include #include #include @@ -102,3 +104,8 @@ unsigned long northbridge_write_acpi_tables(const struct device *const dev, return current; } + +size_t size_of_dnvs(void) +{ + return sizeof(struct device_nvs); +} -- cgit v1.2.3