From 73d1980d23ab3ec95f67c8c881584c6bdea3f746 Mon Sep 17 00:00:00 2001 From: Bora Guvendik Date: Fri, 8 Nov 2024 14:23:41 -0800 Subject: soc/intel/pantherlake/acpi: Update camera_clock_ctl.asl Fix ISCLK register definitions Reference: 813032 - Panther Lake H I/O Registers BUG=b:357011633 TEST=check camera functionality on fatcat Change-Id: Ie9f1f639970344eb359dee37914ee26a02dcfb4b Signed-off-by: Bora Guvendik Reviewed-on: https://review.coreboot.org/c/coreboot/+/85058 Reviewed-by: Subrata Banik Tested-by: build bot (Jenkins) Reviewed-by: Kapil Porwal Reviewed-by: Pranava Y N --- src/soc/intel/pantherlake/acpi/camera_clock_ctl.asl | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) (limited to 'src/soc') diff --git a/src/soc/intel/pantherlake/acpi/camera_clock_ctl.asl b/src/soc/intel/pantherlake/acpi/camera_clock_ctl.asl index aded020d5f..1bdd07e40f 100644 --- a/src/soc/intel/pantherlake/acpi/camera_clock_ctl.asl +++ b/src/soc/intel/pantherlake/acpi/camera_clock_ctl.asl @@ -1,8 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ #define R_ICLK_PCR_CAMERA1 0x8000 -#define B_ICLK_PCR_FREQUENCY 0x1 -#define B_ICLK_PCR_REQUEST 0x2 +#define B_ICLK_PCR_FREQUENCY 0x3 +#define B_ICLK_PCR_REQUEST 0x4 /* The clock control registers for each IMGCLK are offset by 0xC */ #define B_ICLK_PCR_OFFSET 0xC @@ -32,7 +32,11 @@ Scope (\_SB.PCI0) { /* * Clock control Method * Arg0: Clock source select (0 .. 5 => IMGCLKOUT_0 .. IMGCLKOUT_5) - * Arg1: Frequency select (0: 24MHz, 1: 19.2MHz) + * Arg1: Frequency select + * 2'b00 - 19p2 XTAL + * 2'b01 - 19p2 IMG + * 2'b10 - 19p2 RTC + * 2'b11 - 24 IMG */ Method (MCON, 0x2, NotSerialized) { -- cgit v1.2.3