From 71375621354b52f8e8d92ab320a04c563d7024da Mon Sep 17 00:00:00 2001 From: Felix Held Date: Thu, 12 Jan 2023 23:11:54 +0100 Subject: soc/amd/glinda: use common SMU S3/4/5 entry message code Signed-off-by: Felix Held Change-Id: I62b15d59cc4a5f214e45c3995f651228b1ae6ea7 Reviewed-on: https://review.coreboot.org/c/coreboot/+/71900 Reviewed-by: Eric Lai Tested-by: build bot (Jenkins) Reviewed-by: Fred Reitberger --- src/soc/amd/glinda/Kconfig | 1 + src/soc/amd/glinda/Makefile.inc | 1 - src/soc/amd/glinda/smu.c | 19 ------------------- 3 files changed, 1 insertion(+), 20 deletions(-) delete mode 100644 src/soc/amd/glinda/smu.c (limited to 'src/soc') diff --git a/src/soc/amd/glinda/Kconfig b/src/soc/amd/glinda/Kconfig index 4db1193dfa..7b0b7365dd 100644 --- a/src/soc/amd/glinda/Kconfig +++ b/src/soc/amd/glinda/Kconfig @@ -65,6 +65,7 @@ config SOC_AMD_GLINDA select SOC_AMD_COMMON_BLOCK_SMI # TODO: Check if this is still correct select SOC_AMD_COMMON_BLOCK_SMM # TODO: Check if this is still correct select SOC_AMD_COMMON_BLOCK_SMU # TODO: Check if this is still correct + select SOC_AMD_COMMON_BLOCK_SMU_SX_ENTRY # TODO: Check if this is still correct select SOC_AMD_COMMON_BLOCK_SPI # TODO: Check if this is still correct select SOC_AMD_COMMON_BLOCK_TSC_FAM17H_19H # TODO: Check if this is still correct select SOC_AMD_COMMON_BLOCK_UART # TODO: Check if this is still correct diff --git a/src/soc/amd/glinda/Makefile.inc b/src/soc/amd/glinda/Makefile.inc index 76c6689681..3e50011523 100644 --- a/src/soc/amd/glinda/Makefile.inc +++ b/src/soc/amd/glinda/Makefile.inc @@ -47,7 +47,6 @@ ramstage-y += xhci.c smm-y += gpio.c smm-y += smihandler.c -smm-y += smu.c smm-$(CONFIG_DEBUG_SMI) += uart.c CPPFLAGS_common += -I$(src)/soc/amd/glinda/include diff --git a/src/soc/amd/glinda/smu.c b/src/soc/amd/glinda/smu.c deleted file mode 100644 index d8cd081bad..0000000000 --- a/src/soc/amd/glinda/smu.c +++ /dev/null @@ -1,19 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include -#include -#include - -/* TODO: can this be made common? */ - -/* - * Request the SMU to put system into S3, S4, or S5. On entry, SlpTyp determines S-State and - * SlpTypeEn gets set by the SMU. Function does not return if successful. - */ -void smu_sx_entry(void) -{ - struct smu_payload msg = { 0 }; /* Unused for SMC_MSG_S3ENTRY */ - - printk(BIOS_DEBUG, "SMU: Put system into S3/S4/S5\n"); - send_smu_message(SMC_MSG_S3ENTRY, &msg); -} -- cgit v1.2.3