From 6f75dd0fd0c6a9eac570ead978a6da67d8e65aa7 Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Sat, 24 Apr 2021 10:53:19 +0200 Subject: sandybridge,haswell,broadwell: Use DIV_ROUND_CLOSEST macro Integer division in C truncates toward zero. When the dividend and the divisor are positive, one can add half of the divisor to the dividend to round the division result towards the closest integer. We already have a macro in commonlib to do just that, so put it to good use. Tested with BUILD_TIMELESS=1, coreboot images for the Asus P8Z77-V LX2 and the Asrock B85M Pro4 do not change. Change-Id: I251af82da15049a3a2aa6ea712ae8c9fe859caf6 Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/52651 Reviewed-by: Nico Huber Reviewed-by: Benjamin Doron Tested-by: build bot (Jenkins) --- src/soc/intel/broadwell/raminit.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/soc') diff --git a/src/soc/intel/broadwell/raminit.c b/src/soc/intel/broadwell/raminit.c index c55e755055..cacf8ecc89 100644 --- a/src/soc/intel/broadwell/raminit.c +++ b/src/soc/intel/broadwell/raminit.c @@ -16,6 +16,7 @@ #include #include #include +#include static void save_mrc_data(struct pei_data *pei_data) { @@ -46,7 +47,7 @@ static void report_memory_config(void) const u32 addr_decoder_common = mchbar_read32(MAD_CHNL); printk(BIOS_DEBUG, "memcfg DDR3 clock %d MHz\n", - (mchbar_read32(MC_BIOS_DATA) * 13333 * 2 + 50) / 100); + DIV_ROUND_CLOSEST(mchbar_read32(MC_BIOS_DATA) * 13333 * 2, 100)); printk(BIOS_DEBUG, "memcfg channel assignment: A: %d, B % d, C % d\n", (addr_decoder_common >> 0) & 3, -- cgit v1.2.3