From 6a07db21b12b08c7b975921f2ee1196dd0ec92b3 Mon Sep 17 00:00:00 2001 From: Nico Huber Date: Fri, 12 May 2023 15:46:24 +0200 Subject: console: Add format-checking __printf() to die() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Code changes are necessary because `-Wformat` warns about empty format strings by default. Change-Id: Ic8021b70f4cd4875b06f196f88b84940c9a79fe0 Signed-off-by: Nico Huber Reviewed-on: https://review.coreboot.org/c/coreboot/+/75147 Reviewed-by: Jérémy Compostella Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons Reviewed-by: Arthur Heymans --- src/soc/intel/xeon_sp/chip_common.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'src/soc') diff --git a/src/soc/intel/xeon_sp/chip_common.c b/src/soc/intel/xeon_sp/chip_common.c index f6805b2032..a9b1260646 100644 --- a/src/soc/intel/xeon_sp/chip_common.c +++ b/src/soc/intel/xeon_sp/chip_common.c @@ -40,8 +40,7 @@ static RES_TYPE get_res_type(uint64_t flags) /* both 64-bit and 32-bit use below 4GB address space */ return RES_TYPE_NONPREF_MEM; } - printk(BIOS_ERR, "Invalid resource type 0x%llx\n", flags); - die(""); + die("Invalid resource type 0x%llx\n", flags); } static bool need_assignment(uint64_t flags) -- cgit v1.2.3