From 4b1f4e3a993fe42bdc83966fba0d657a12d023d4 Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Mon, 25 Apr 2022 15:28:19 +0530 Subject: soc/intel/cmn/cse: Drop redundant macro check for heci1_disable() This patch removes redundant DISABLE_HECI1_AT_PRE_BOOT config check for heci1_disable(), once by caller (from various SoC) and again inside the callee (heci1_disable) function. As all callers of heci1_disable() function are doing DISABLE_HECI1_AT_PRE_BOOT config enabled check, hence, the second check inside the callee can be dropped. BUG=b:228789015 TEST=Able to build and boot google/redrix with this change. CSE PCI device is getting function disabled upon selecting DISABLE_HECI1_AT_PRE_BOOT from SoC config. Signed-off-by: Subrata Banik Change-Id: I47d7a9989e355987618d089f79c3340fcf4953ad Reviewed-on: https://review.coreboot.org/c/coreboot/+/63821 Tested-by: build bot (Jenkins) Reviewed-by: Eric Lai Reviewed-by: Sridhar Siricilla Reviewed-by: Angel Pons --- src/soc/intel/common/block/cse/disable_heci.c | 3 --- 1 file changed, 3 deletions(-) (limited to 'src/soc') diff --git a/src/soc/intel/common/block/cse/disable_heci.c b/src/soc/intel/common/block/cse/disable_heci.c index 84a09fd3b2..625de75bb7 100644 --- a/src/soc/intel/common/block/cse/disable_heci.c +++ b/src/soc/intel/common/block/cse/disable_heci.c @@ -83,9 +83,6 @@ static void heci1_disable_using_sbi(void) void heci1_disable(void) { - if (!CONFIG(DISABLE_HECI1_AT_PRE_BOOT)) - return; - if (ENV_SMM && CONFIG(SOC_INTEL_COMMON_BLOCK_HECI1_DISABLE_USING_SBI)) { printk(BIOS_INFO, "Disabling Heci using SBI in SMM mode\n"); return heci1_disable_using_sbi(); -- cgit v1.2.3