From 3f4ed7a40b8bfecaf4064356774036d43dd06d42 Mon Sep 17 00:00:00 2001 From: Patrick Rudolph Date: Fri, 21 Dec 2018 11:14:31 +0100 Subject: soc/intel/fsp_broadwell_de/acpi: Fix wrong table checksum Fix the following warning shown in dmesg: "ACPI BIOS Warning (bug): Incorrect checksum in table [FACP]" The table checksum was wrong as it was calculated twice and with the second time the checksum field wasn't set to zero. Change-Id: I375354bf3e95ebdac3b0dad43659d72c6ab3175a Signed-off-by: Patrick Rudolph Reviewed-on: https://review.coreboot.org/c/30353 Tested-by: build bot (Jenkins) Reviewed-by: Jay Talbott Reviewed-by: Arthur Heymans --- src/soc/intel/fsp_broadwell_de/acpi.c | 2 -- 1 file changed, 2 deletions(-) (limited to 'src/soc') diff --git a/src/soc/intel/fsp_broadwell_de/acpi.c b/src/soc/intel/fsp_broadwell_de/acpi.c index d5bee64a24..ad88313ade 100644 --- a/src/soc/intel/fsp_broadwell_de/acpi.c +++ b/src/soc/intel/fsp_broadwell_de/acpi.c @@ -307,8 +307,6 @@ void acpi_fill_in_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt) fadt->x_gpe1_blk.access_size = 0; fadt->x_gpe1_blk.addrl = fadt->gpe1_blk; fadt->x_gpe1_blk.addrh = 0x00; - - header->checksum = acpi_checksum((void *) fadt, sizeof(acpi_fadt_t)); } static unsigned long acpi_fill_dmar(unsigned long current) -- cgit v1.2.3