From 3858fb121e4322f7a835b23622bf9452790fcec6 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Sat, 27 Jun 2020 15:11:36 +0200 Subject: soc/amd/picasso: add NULL-pointer check to root_complex_fill_ssdt Found-by: Coverity CID 1429980 Change-Id: Ia72b9dbe029a5da98e408a9cf16fa4a93b10917a Signed-off-by: Felix Held Reviewed-on: https://review.coreboot.org/c/coreboot/+/42846 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Rudolph Reviewed-by: Raul Rangel --- src/soc/amd/picasso/root_complex.c | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'src/soc') diff --git a/src/soc/amd/picasso/root_complex.c b/src/soc/amd/picasso/root_complex.c index 4930a0e87f..036ff00ccb 100644 --- a/src/soc/amd/picasso/root_complex.c +++ b/src/soc/amd/picasso/root_complex.c @@ -135,6 +135,12 @@ static void root_complex_fill_ssdt(const struct device *device) { msr_t msr; + if (!device) { + printk(BIOS_ERR, "%s: device is NULL! ACPI SSDT will be incomplete.\n", + __func__); + return; + } + acpigen_write_scope(acpi_device_scope(device)); msr = rdmsr(TOP_MEM); -- cgit v1.2.3