From 3051cd9265b8eb29742a66fc67db083289fa07e5 Mon Sep 17 00:00:00 2001 From: Martin Roth Date: Wed, 11 Jan 2017 10:57:09 -0700 Subject: soc/marvell/mvmap2315: Mark mvmap2315_reset() as noreturn mvmap2315_reset() is called from locations where we're checking for NULL pointers. Because coverity can't tell from the code that the functions are not returning, it's showing errors of accessing pointers after we've determined that they're invalid. Mark it as noreturn, and add a loop in case the reset isn't on the next instruction. This probably isn't needed, but shouldn't hurt. Found-by: Coverity Scan #1362809 Change-Id: If93084629d5c2c8dc232558f2559b78b1ca5de7c Signed-off-by: Martin Roth Reviewed-on: https://review.coreboot.org/18103 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Nico Huber --- src/soc/marvell/mvmap2315/reset.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/soc') diff --git a/src/soc/marvell/mvmap2315/reset.c b/src/soc/marvell/mvmap2315/reset.c index 531f4a0b50..40067ed7ab 100644 --- a/src/soc/marvell/mvmap2315/reset.c +++ b/src/soc/marvell/mvmap2315/reset.c @@ -21,8 +21,9 @@ #include #include -void mvmap2315_reset(void) +void __attribute__((noreturn)) mvmap2315_reset(void) { clrbits_le32(&mvmap2315_mpmu_clk->resetmcu, MVMAP2315_MCU_RST_EN); clrbits_le32(&mvmap2315_mpmu_clk->resetap, MVMAP2315_AP_RST_EN); + for (;;) ; } -- cgit v1.2.3