From 2049bb9b2c04738388ae97b6ed6e84e1be84ae21 Mon Sep 17 00:00:00 2001 From: Karthikeyan Ramasubramanian Date: Wed, 17 May 2023 17:36:19 -0600 Subject: soc/amd/common/psp_verstage: Always build unsigned PSP verstage Currently unsigned PSP verstage binary is copied from ELF file only when required in amdfw*.rom. If a signed PSP verstage binary is supplied while building amdfw*.rom, then it is dropped. Copy the unsigned PSP verstage binary always so that it can be used for signing directly from the CI build infrastructure instead of a locally built binary. BUG=None TEST=Build Skyrim BIOS image and ensure that the unsigned PSP verstage is part of the build artifacts. Change-Id: If797dcfd20aa2991f3517904ef862406b9b9875c Signed-off-by: Karthikeyan Ramasubramanian Reviewed-on: https://review.coreboot.org/c/coreboot/+/75334 Reviewed-by: Raul Rangel Reviewed-by: Matt DeVillier Tested-by: build bot (Jenkins) --- src/soc/amd/common/psp_verstage/Makefile.inc | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'src/soc') diff --git a/src/soc/amd/common/psp_verstage/Makefile.inc b/src/soc/amd/common/psp_verstage/Makefile.inc index 54e1d0a37f..ee71d9930e 100644 --- a/src/soc/amd/common/psp_verstage/Makefile.inc +++ b/src/soc/amd/common/psp_verstage/Makefile.inc @@ -25,3 +25,10 @@ verstage-y += vboot_crypto.c $(obj)/psp_verstage.bin: $(objcbfs)/verstage.elf $(OBJCOPY_verstage) -O binary $^ $@ + +# Default CONFIG_PSP_VERSTAGE_FILE configuration requires psp_verstage.bin and the above +# build rule takes effect. Once CONFIG_PSP_VERSTAGE_FILE is overridden with signed PSP +# verstage, then psp_verstage.bin is not built. The following build rule ensures that the +# unsigned psp_verstage.bin is still built even when not used so that it can be used for +# signing purposes. +build_complete:: $(obj)/psp_verstage.bin -- cgit v1.2.3