From 14908bf05ad3cb5a44c1a0a8197f04e5cd8658d9 Mon Sep 17 00:00:00 2001 From: Jeremy Compostella Date: Tue, 7 Jun 2022 10:25:43 -0700 Subject: soc/intel/alderlake: remove unnecessary test condition mch_id is set to zero and then unnecessarily tested. TEST=build and boot image on ADL RVP board Signed-off-by: Jeremy Compostella Change-Id: I20734e1638714027b976043b3a0457cbf3cd8442 Reviewed-on: https://review.coreboot.org/c/coreboot/+/65121 Reviewed-by: Bora Guvendik Reviewed-by: Sridhar Siricilla Reviewed-by: Cliff Huang Tested-by: build bot (Jenkins) --- src/soc/intel/alderlake/vr_config.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) (limited to 'src/soc') diff --git a/src/soc/intel/alderlake/vr_config.c b/src/soc/intel/alderlake/vr_config.c index 569fd845d8..1cef07a103 100644 --- a/src/soc/intel/alderlake/vr_config.c +++ b/src/soc/intel/alderlake/vr_config.c @@ -181,13 +181,9 @@ void fill_vr_domain_config(FSP_S_CONFIG *s_cfg, s_cfg->TdcTimeWindow[domain] = cfg->tdc_timewindow; s_cfg->TdcCurrentLimit[domain] = cfg->tdc_currentlimit; } else { - uint16_t mch_id = 0; uint8_t tdp = get_cpu_tdp(); - - if (!mch_id) { - struct device *dev = pcidev_path_on_root(SA_DEVFN_ROOT); - mch_id = dev ? pci_read_config16(dev, PCI_DEVICE_ID) : 0xffff; - } + struct device *dev = pcidev_path_on_root(SA_DEVFN_ROOT); + uint16_t mch_id = dev ? pci_read_config16(dev, PCI_DEVICE_ID) : 0xffff; s_cfg->AcLoadline[domain] = load_table(vr_config_ll, ARRAY_SIZE(vr_config_ll), domain, mch_id, tdp); -- cgit v1.2.3